✨ 📖 Minor updates to API+GoDoc, Documentation, and removal of a no longer needed label selector #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
==========================================
+ Coverage 76.37% 76.42% +0.05%
==========================================
Files 41 41
Lines 2438 2431 -7
==========================================
- Hits 1862 1858 -4
+ Misses 402 400 -2
+ Partials 174 173 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
openshift-merge-robot
added
the
needs-rebase
joelanford
reviewed
Oct 4, 2024
joelanford
reviewed
Oct 4, 2024
everettraven
force-pushed
the
chore/minor-updates
branch
from
c8ef566
to
f429d71
Compare
openshift-merge-robot
removed
the
needs-rebase
joelanford
previously approved these changes
Oct 4, 2024
Signed-off-by: everettraven <everettraven@gmail.com>
everettraven
force-pushed
the
chore/minor-updates
branch
from
f429d71
to
63e6e73
Compare
joelanford
approved these changes
Oct 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
operator-framework:main
with commit Oct 4, 2024
02d2879
18 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dependentSelectorlabel selector requirement placed as the default label selector for our controller-runtime cache. This was necessary when we used native controller-runtime logic for managing dependent resources, but is no longer necessary now that we have some custom implementations of controller-runtime abstractions that use ServiceAccounts to establish informers and manage dependent resources.ClusterExtension.Status.Conditionsfield to reflect the new set of potential status conditions and reasonsReviewer Checklist