Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ updated to use catalogd v0.34.0 #1396

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

grokspawn
Copy link
Contributor

see
catalogd v0.34.0 release notes for more details

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@grokspawn grokspawn requested a review from a team as a code owner October 18, 2024 20:31
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 6449afd
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6712c9d604d211000826ac5f
😎 Deploy Preview https://deploy-preview-1396--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@grokspawn grokspawn changed the title updated to use catalogd v0.34.0 ⚠️ updated to use catalogd v0.34.0 Oct 18, 2024
@joelanford
Copy link
Member

I see more references to all.json and Content URL in the docs that need to be fixed up.

$ rg 'all.json'
docs/howto/catalog-queries.md
10:curl -k https://localhost:8443/catalogs/operatorhubio/all.json | <query>

docs/tutorials/explore-available-content.md
29:    curl -k https://localhost:8443/catalogs/operatorhubio/all.json | jq -s '.[] | select(.schema == "olm.package") | .name'
99:        curl -k https://localhost:8443/catalogs/operatorhubio/all.json | jq -c 'select(.schema == "olm.bundle") | {"package":.package, "version":.properties[] | select(.type == "olm.bundle.object").value.data | @base64d | fromjson | select(.kind == "ClusterServiceVersion" and (.spec.installModes[] | select(.type == "AllNamespaces" and .supported == true) != null) and .spec.webhookdefinitions == null).spec.version}'
130:    curl -k https://localhost:8443/catalogs/operatorhubio/all.json | jq -s '.[] | select( .schema == "olm.package") | select( .name == "<package_name>")'

docs/tutorials/add-catalog.md
129:          Content URL:             https://catalogd-server.olmv1-system.svc/catalogs/operatorhubio/all.json

see
[catalogd v0.34.0 release notes](https://github.com/operator-framework/catalogd/releases/tag/v0.34.0) for more details

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@joelanford
Copy link
Member

joelanford commented Oct 18, 2024

I'm guessing @perdasilva 's hack scripts also have to be updated.

Nvmd: I see you found the download-catalog one. Maybe that's all there is.

@grokspawn
Copy link
Contributor Author

grokspawn commented Oct 18, 2024

Nvmd: I see you found the download-catalog one. Maybe that's all there is.

Yeah. First pass was functional (and I didn't recognize Per's hack script as such, so I erred on the side of caution and treated it as functional.
Second pass was docs, and I think now I've caught all of them.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.31%. Comparing base (3083879) to head (6449afd).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/catalogmetadata/client/client.go 25.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1396      +/-   ##
==========================================
- Coverage   73.44%   73.31%   -0.14%     
==========================================
  Files          42       42              
  Lines        3159     3166       +7     
==========================================
+ Hits         2320     2321       +1     
- Misses        655      659       +4     
- Partials      184      186       +2     
Flag Coverage Δ
e2e 54.83% <25.00%> (-0.09%) ⬇️
unit 52.55% <25.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford joelanford added this pull request to the merge queue Oct 18, 2024
Merged via the queue into operator-framework:main with commit bfa0435 Oct 18, 2024
17 of 20 checks passed
@grokspawn grokspawn deleted the catd-versioned-api branch October 18, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants