Skip to content

Commit

Permalink
[#50519] Project storage members page can be accessed without a session.
Browse files Browse the repository at this point in the history
  • Loading branch information
ba1ash committed Oct 13, 2023
1 parent 1270460 commit 7df4f7a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
# Purpose: Let OpenProject create folders per project automatically.
# This is recommended as it ensures that every team member always has the correct access permissions.
#
class Storages::ProjectSettings::ProjectStorageMembersController < ApplicationController
class Storages::ProjectSettings::ProjectStorageMembersController < Projects::SettingsController
include PaginationHelper

menu_item :settings_project_storages
Expand Down Expand Up @@ -61,6 +61,5 @@ def find_model_object(object_id = :project_storage_id)
super(object_id)
@project_storage = @object
@storage = @project_storage.storage
@project = @project_storage.project
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@
connected_no_permissions_user])
end

it 'cannot be accessed without being logged in' do
visit project_settings_project_storage_members_path(project, project_storage_id: project_storage.id)

expect(page).to have_title('Sign in | OpenProject')
expect(page).not_to have_text('Members connection status')
end

it 'lists project members connection statuses' do
login_as user

Expand Down

0 comments on commit 7df4f7a

Please sign in to comment.