Merge pull request #196 from opf/test/ci

Change model default for editable PageHeader title
opf · Oct 24, 2024 · a18340c · a18340c
2 parents 01ce364 + 40b8fda
commit a18340c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/fast-pants-rhyme.md b/.changeset/fast-pants-rhyme.md
@@ -0,0 +1,5 @@
+---
+'@openproject/primer-view-components': patch
+---
+
+Change default for model in PageHeader title form to "false"
diff --git a/app/components/primer/open_project/page_header/title.rb b/app/components/primer/open_project/page_header/title.rb
@@ -11,7 +11,7 @@ class Title < Primer::Component
         HEADING_TAG_OPTIONS = [:h1, :h2, :h3, :h4, :h5, :h6].freeze
         HEADING_TAG_FALLBACK = :h1
 
-        renders_one :editable_form, lambda { |model: nil, update_path:, cancel_path:, input_name: :title, method: :put, label: I18n.t(:label_title), placeholder: I18n.t(:label_title), **system_arguments|
+        renders_one :editable_form, lambda { |model: false, update_path:, cancel_path:, input_name: :title, method: :put, label: I18n.t(:label_title), placeholder: I18n.t(:label_title), **system_arguments|
           primer_form_with(
             model: model,
             method: method,

diff --git a/test/components/primer/open_project/page_header_test.rb b/test/components/primer/open_project/page_header_test.rb
@@ -251,7 +251,7 @@ def test_renders_segmented_control
   def test_renders_editable_title
     render_inline(Primer::OpenProject::PageHeader.new(state: :edit)) do |header|
       header.with_title do |title|
-        title.with_editable_form(model: nil, update_path: "/foo", cancel_path: "/bar")
+        title.with_editable_form(update_path: "/foo", cancel_path: "/bar")
         "Hello"
       end