Fix #5039 : Align policy text and symbols to the left, partial fix for list items #5573

TanishMoral11 · 2024-11-07T14:30:33Z

Fix #5039: This PR addresses the issue described by ensuring that policy text and special symbols (such as bullet points and question marks) within policy descriptions are aligned to the left. The content now displays correctly in an LTR (left-to-right) format. However, this is only a partial fix as there are still outstanding issues with the alignment of <li> (list item) tags.

Implemented Changes:

Used LeftAlignedSymbolsSpan to ensure text and symbols are left-aligned.
Modified PoliciesFragmentPresenter to parse and format the text appropriately for LTR display.

Known Limitations:

Alignment for <li> tags within parsed HTML content is not fully resolved. Further work is required to properly align list items.

Essential Checklist

The PR title and explanation start with "Fix [BUG]: Terms of Service and Privacy Policy content should still be left-aligned, even if the app is in an RTL language. #5039".
Changes to any scripts or assets are justified.
The PR follows the coding style guide.
Unnecessary code changes from Android Studio are not included.
The branch is up-to-date and not named develop.
The PR is assigned to relevant reviewers.

Progress Till Now :-

2024-11-07_19-52-22.mp4

TanishMoral11 · 2024-11-07T14:35:05Z

Hey @adhiamboperes ,

I have created a draft PR addressing #5039 , which focuses on ensuring that policy text and symbols (such as bullet points and question marks) are aligned to the left in an LTR format. While this change improves the overall text alignment, there remains an outstanding issue with the alignment of <li> (list item) tags when rendered within parsed HTML content.

Issue Summary:

Although most text and individual symbols are now correctly aligned, list items created using the <li> tag within the policy descriptions are not fully aligned to the left. The current span-based approach successfully formats standard text and symbols but does not affect <li> elements, leading to inconsistencies in the displayed content.

Request for Guidance:

I kindly ask for your insights or recommendations on potential solutions for handling the alignment of <li> tags in this context. Specifically, any advice on:

Custom parsing strategies that could be employed for list elements.
Advanced spans or Android-specific methods to ensure <li> tags align correctly within parsed text.

Thanks !!

TanishMoral11 · 2024-11-11T19:39:39Z

Hey @adhiamboperes PTAL

oppiabot · 2024-11-11T19:42:43Z

Unassigning @TanishMoral11 since a re-review was requested. @TanishMoral11, please make sure you have addressed all review comments. Thanks!

adhiamboperes · 2024-11-12T11:09:21Z

Thanks @TanishMoral11! The solution for bullets look good. As for the items in

tags, One approach attempted by @Vishwajith-Shettigar was to take the raw string, like val policyDescription and use regex to extract the reguired tag (in this case li) and apply the necessary formatting, then setting the mofidified string to the textview. E.g. in https://github.com/oppia/oppia-android/pull/5286/files and https://github.com/oppia/oppia-android/pull/5212/files.

TanishMoral11 · 2024-11-12T19:15:11Z

Hey @adhiamboperes , PTAL

2024-11-13_00-39-44.mp4

oppiabot · 2024-11-12T19:23:18Z

Unassigning @TanishMoral11 since a re-review was requested. @TanishMoral11, please make sure you have addressed all review comments. Thanks!

adhiamboperes

Thanks @TanishMoral11.

While the solution appears correct, a number of cleanup changes are required to get the PR merge ready.

Also, the video you have uploaded in the comments does not play. Please re-upload it to the PR description and ensure it can play.

utility/src/main/java/org/oppia/android/util/parser/html/HtmlParser.kt

utility/src/main/java/org/oppia/android/util/parser/html/LiTagHandler.kt

utility/src/main/java/org/oppia/android/util/parser/html/ListItemLeadingMarginSpan.kt

…ructure

TanishMoral11 · 2024-11-14T18:17:48Z

Hey @adhiamboperes PTAL ,

Thank you for your detailed review and valuable feedback.

I have addressed all your requested adjustments, including:

Retaining the separation of the create methods as per your guidance to preserve their distinct purposes.
Reverting to named arguments for improved readability, following your recommendation.
Ensuring minor formatting issues have been resolved, including inserting new lines at EOF where necessary.

Additionally, I have re-uploaded the video demonstration to the PR description, ensuring it is now accessible and plays correctly.

Thank you again for your guidance. I look forward to your review of these updates. Please let me know if there are any further adjustments needed.

2024-11-13_00-39-44.mp4

oppiabot · 2024-11-14T18:20:53Z

Unassigning @TanishMoral11 since a re-review was requested. @TanishMoral11, please make sure you have addressed all review comments. Thanks!

TanishMoral11 · 2024-12-10T15:13:17Z

Hey @adhiamboperes Could You PTAL ,

Explanation of Implementation

I’ve made updates to handle the left alignment of text, especially bullet points, in the Policies page for both RTL and LTR layouts.

Left-Aligned Bullet Points:
A custom span (LeftAlignedSymbolsSpan) was added to ensure that bullet points are always left-aligned, regardless of text direction.
Text Alignment Adjustments:
The text in the policy description was explicitly set to left-aligned for both layout direction (View.LAYOUT_DIRECTION_LTR) and text direction (View.TEXT_DIRECTION_LTR), ensuring consistent presentation.

Test Passed Screen Shot :

After Changes Video :
https://github.com/user-attachments/assets/db3a82db-4a71-4aeb-b483-9eb822da7080

oppiabot · 2024-12-10T15:16:22Z

Unassigning @TanishMoral11 since a re-review was requested. @TanishMoral11, please make sure you have addressed all review comments. Thanks!

adhiamboperes

Thanks @TanishMoral11!

I have some clarifications, and a few comments to solve the CI failures.

Please fix the unuused attribute error utility/src/main/java/org/oppia/android/util/parser/html/ListItemLeadingMarginSpan.kt:149:13: warning: variable 'textWidth' is never used
LeftAlignedSymbolsSpan.kt is a new class, but it does not seem to have been added to a Bazel BUILD file, so Bazel may not be able to find it during build.
Is locale the correct package for LeftAlignedSymbolsSpan? Please verify that that is the same packake where similar utilities are created.

Lastly, please do a spot check in a few lessons/revision cards to verify that the bullets behavior remains unaffected.

utility/src/main/java/org/oppia/android/util/parser/html/ListItemLeadingMarginSpan.kt

adhiamboperes · 2024-12-16T06:40:42Z

utility/src/main/java/org/oppia/android/util/locale/LeftAlignedSymbolsSpan.kt

+// Custom span to force LTR alignment for symbols as well
+// Custom span to force LTR alignment for all text including symbols


This should be a KDOC rather than a comment.

utility/src/main/java/org/oppia/android/util/parser/html/ListItemLeadingMarginSpan.kt

TanishMoral11 · 2024-12-16T17:38:11Z

Thanks @adhiamboperes , PTAL !!

2. [LeftAlignedSymbolsSpan.kt](https://github.com/oppia/oppia-android/pull/5573/files#diff-629cfdb57266c5bf09ed4b58981c9004970b425495035e4eef5655f5cef1d374) is a new class, but it does not seem to have been added to a Bazel BUILD file, so Bazel may not be able to find it during build.

I Added LeftAlignedSymbolsSpan.kt To The Bazel BUILD File But Encountered Test Failures. Could You Help Me Understand Which Tests Are Failing And Any Specific Integration Requirements?

3. Is locale the correct package for LeftAlignedSymbolsSpan? Please verify that that is the same packake where similar utilities are created.

Yeah, You're Right About The Package Location. I Moved LeftAlignedSymbolsSpan To org.oppia.android.util.parser.html Since It's An HTML Parsing Utility.

Lastly, please do a spot check in a few lessons/revision cards to verify that the bullets behavior remains unaffected.

I've Tested The App, And As Yet No Misbehavior Was Detected Related To These Changes.

oppiabot · 2024-12-16T17:41:15Z

Unassigning @TanishMoral11 since a re-review was requested. @TanishMoral11, please make sure you have addressed all review comments. Thanks!

adhiamboperes

Apologies for taking a while to review this, @TanishMoral11.

A few points to note on Bazel:

I have taken a look at your CI failures. The latest error is app/policies/PoliciesFragmentPresenter_updated.kt:78:56: warning: parameter 'lineIndex' is never used, could be renamed to _ parsedHtmlDescription.split("\n").forEachIndexed { lineIndex, line ->. Unless you fix this error, you won't be able to see if there are additional errors.
You can read this wiki page for information on how to read Bazel CI errors. A youtube video is also linked.
You should set aside some time to set up the project build in Bazel, so that you can run Bazel builds locally. Additionally, some more advanced issues you'll encounter will require you to have Bazel set up. The discussions section will be helpful in searching for solutions to some common setup issues.

adhiamboperes · 2024-12-23T14:04:51Z

utility/src/main/java/org/oppia/android/util/parser/html/BUILD.bazel

@@ -46,6 +46,7 @@ kt_android_library(
    name = "list_item_leading_margin_span",
    srcs = [
        "ListItemLeadingMarginSpan.kt",
+        "LeftAlignedSymbolsSpan.kt",


@TanishMoral11, to answer your question regarding adding this class to the build file:

Sometimes a kt lib can have multiple source files like you have added here, and for tag_handlers, but it depends on usecase. E.g., if you want to use LeftAlignedSymbolsSpan in a different part of the codepase, you will need to add a dependency on the lib, list_item_leading_margin_span, which will provide both ListItemLeadingMarginSpan and LeftAlignedSymbolsSpan. On the other hand, each class can have it's own lib if they are only used in a standalone way, like most of the other utility classes in this package and their corresponding libs in this BUILD file.

…hMoral11/oppia-android into left-align-policy-text-fix

github-actions · 2024-12-25T03:44:01Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 1548 bytes (Added)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 1585 bytes (Added)

Method count: 260202 (old), 260198 (new), 4 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6818 (old), 6818 (new), 0 (No change)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 380 (new), 0 (No change)
Id: 1275 (old), 1275 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 852 (old), 852 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 1552 bytes (Added)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 658 bytes (Added)
Method count: 260202 (old), 260198 (new), 4 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 264 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 36 bytes (Added)

Method count: 116280 (old), 116271 (new), 9 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5786 (old), 5785 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 779 (new), 1 (Removed):
- dimen/spacing_before_text (removed)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 785 (old), 785 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 264 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 165 bytes (Added)
Method count: 116280 (old), 116271 (new), 9 (Removed)
Resources: 5743 (old), 5742 (new), 1 (Removed)

Dimen: 778 (old), 777 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 1113 bytes (Added)

Method count: 116286 (old), 116277 (new), 9 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5786 (old), 5785 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 779 (new), 1 (Removed):
- dimen/spacing_before_text (removed)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 785 (old), 785 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 385 bytes (Added)
Method count: 116286 (old), 116277 (new), 9 (Removed)
Resources: 5743 (old), 5742 (new), 1 (Removed)

Dimen: 778 (old), 777 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 52 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 1112 bytes (Removed)

Method count: 116286 (old), 116277 (new), 9 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5786 (old), 5785 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 779 (new), 1 (Removed):
- dimen/spacing_before_text (removed)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 785 (old), 785 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 48 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 33 bytes (Removed)
Method count: 116286 (old), 116277 (new), 9 (Removed)
Resources: 5743 (old), 5742 (new), 1 (Removed)

Dimen: 778 (old), 777 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

TanishMoral11 · 2024-12-25T12:40:07Z

Hey @adhiamboperes , PTAL !!

oppiabot · 2024-12-25T12:43:11Z

Unassigning @TanishMoral11 since a re-review was requested. @TanishMoral11, please make sure you have addressed all review comments. Thanks!

Align policy text and symbols to the left, partial fix for list items

f8143d2

TanishMoral11 requested review from a team as code owners November 7, 2024 14:30

TanishMoral11 requested a review from BenHenning November 7, 2024 14:30

TanishMoral11 marked this pull request as draft November 7, 2024 14:31

adhiamboperes assigned TanishMoral11 Nov 7, 2024

oppiabot bot assigned adhiamboperes and unassigned TanishMoral11 Nov 11, 2024

adhiamboperes changed the title ~~Fix #5039 : Align policy text and symbols to the left, partial fix for list items~~ Fix part of #5039 : Align policy text and symbols to the left, partial fix for list items Nov 12, 2024

adhiamboperes assigned TanishMoral11 and unassigned adhiamboperes Nov 12, 2024

Fix text alignment and bullet point formatting in PoliciesFragment

fdb0929

TanishMoral11 marked this pull request as ready for review November 12, 2024 19:16

oppiabot bot assigned adhiamboperes and unassigned TanishMoral11 Nov 12, 2024

TanishMoral11 changed the title ~~Fix part of #5039 : Align policy text and symbols to the left, partial fix for list items~~ Fix #5039 : Align policy text and symbols to the left, partial fix for list items Nov 12, 2024

adhiamboperes requested changes Nov 14, 2024

View reviewed changes

adhiamboperes assigned TanishMoral11 and unassigned adhiamboperes Nov 14, 2024

Fix: Remove unnecessary formatting changes and maintain consistent st…

b5148d4

…ructure

oppiabot bot assigned adhiamboperes and unassigned TanishMoral11 Nov 14, 2024

oppiabot bot assigned adhiamboperes and unassigned TanishMoral11 Dec 10, 2024

adhiamboperes requested changes Dec 16, 2024

View reviewed changes

adhiamboperes assigned TanishMoral11 and unassigned adhiamboperes Dec 16, 2024

TanishMoral11 added 5 commits December 16, 2024 13:29

Remove Ununsed Variable

957b27a

Remove Ununsed Variable

061e0a7

Resolved All Issues

a6624fa

Resolved All Issues

73e09dc

Improving Formatting

642f106

TanishMoral11 requested a review from adhiamboperes December 16, 2024 17:39

oppiabot bot assigned adhiamboperes and unassigned TanishMoral11 Dec 16, 2024

Merge branch 'develop' into left-align-policy-text-fix

c14a0a5

adhiamboperes requested changes Dec 23, 2024

View reviewed changes

adhiamboperes assigned TanishMoral11 and unassigned adhiamboperes Dec 23, 2024

TanishMoral11 and others added 3 commits December 24, 2024 09:23

Merge branch 'develop' into left-align-policy-text-fix

5e05035

Removed Unused Variable

eace6d8

Merge branch 'left-align-policy-text-fix' of https://github.com/Tanis…

2fada65

…hMoral11/oppia-android into left-align-policy-text-fix

TanishMoral11 requested a review from adhiamboperes December 25, 2024 12:40

oppiabot bot assigned adhiamboperes and unassigned TanishMoral11 Dec 25, 2024

		// Custom span to force LTR alignment for symbols as well
		// Custom span to force LTR alignment for all text including symbols

Fix #5039 : Align policy text and symbols to the left, partial fix for list items #5573

Are you sure you want to change the base?

Fix #5039 : Align policy text and symbols to the left, partial fix for list items #5573

Conversation

TanishMoral11 commented Nov 7, 2024 • edited Loading

Implemented Changes:

Known Limitations:

Essential Checklist

TanishMoral11 commented Nov 7, 2024

Issue Summary:

Request for Guidance:

TanishMoral11 commented Nov 11, 2024

oppiabot bot commented Nov 11, 2024

adhiamboperes commented Nov 12, 2024

TanishMoral11 commented Nov 12, 2024

oppiabot bot commented Nov 12, 2024

adhiamboperes left a comment

Choose a reason for hiding this comment

TanishMoral11 commented Nov 14, 2024

oppiabot bot commented Nov 14, 2024

TanishMoral11 commented Dec 10, 2024 • edited Loading

Explanation of Implementation

oppiabot bot commented Dec 10, 2024

adhiamboperes left a comment • edited Loading

Choose a reason for hiding this comment

adhiamboperes Dec 16, 2024

Choose a reason for hiding this comment

TanishMoral11 Dec 16, 2024

Choose a reason for hiding this comment

TanishMoral11 commented Dec 16, 2024

oppiabot bot commented Dec 16, 2024

adhiamboperes left a comment

Choose a reason for hiding this comment

adhiamboperes Dec 23, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 25, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

TanishMoral11 commented Nov 7, 2024 •

edited

Loading

TanishMoral11 commented Dec 10, 2024 •

edited

Loading

adhiamboperes left a comment •

edited

Loading