-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5612 Talk back is not reading Arabic language in Preferred Audio Language #5613
Open
subhajitxyz
wants to merge
26
commits into
oppia:develop
Choose a base branch
from
subhajitxyz:fix-talkbackread-arabic
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d819e70
Merge pull request #1 from oppia/develop
subhajitxyz c6f54ea
Merge branch 'oppia:develop' into develop
subhajitxyz d44015b
Merge remote-tracking branch 'upstream/develop' into develop
subhajitxyz d604bc2
Merge pull request #2 from oppia/develop
subhajitxyz cc0ddef
Merge pull request #3 from oppia/develop
subhajitxyz 52c6bb1
Merge pull request #4 from oppia/develop
subhajitxyz 773c810
Merge remote-tracking branch 'upstream/develop' into develop
subhajitxyz 56af5ae
Merge pull request #5 from oppia/develop
subhajitxyz 3883f70
Merge pull request #6 from oppia/develop
subhajitxyz 10c8e6e
Fix #5404: Migrate away from onBackPressed for remaining activities (…
dattasneha 5e140e9
Fix #5404: Migrate away from onBackPressed for RevisionCardActivity (…
dattasneha b4ad7a3
Merge branch 'oppia:develop' into develop
subhajitxyz 238645d
Merge pull request #8 from oppia/develop
subhajitxyz 5a546b9
Merge pull request #9 from oppia/develop
subhajitxyz b1ca8e1
Merge pull request #10 from oppia/develop
subhajitxyz ad7e380
Merge pull request #11 from oppia/develop
subhajitxyz b938a4c
Fix #5508: Skipping redundant code coverage and APK/AAB report commen…
Rd4dev fc2f932
Fix part of #4865: Use profileId in classroom activity and presenter …
tobioyelekan 35f937b
Merge branch 'oppia:develop' into develop
subhajitxyz 21b0986
Merge branch 'oppia:develop' into develop
subhajitxyz d891a5a
Merge branch 'oppia:develop' into develop
subhajitxyz 3e6404d
add content desc and test for arabicDisplayName
subhajitxyz 9312dcf
added kdoc for fun languageContentDescription
subhajitxyz b1d0ca1
add string in string.xml and change test name
subhajitxyz 7c12668
Merge branch 'oppia:develop' into develop
subhajitxyz 6df6480
Merge branch 'develop' of https://github.com/subhajitxyz/oppia-androi…
subhajitxyz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please move this to strings.xml with a descriptive name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adhiamboperes , I have added this to strings.xml. Please check if it is okay.