Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to EISOP #425

Closed
wants to merge 6 commits into from
Closed

Conversation

Ao-senXiong
Copy link

This is the attempt to update opprop checker-framework-inference project to based on the newest version of eisop check-framework.

@Ao-senXiong Ao-senXiong changed the title Update eisop Update to EISOP Aug 17, 2023
@Ao-senXiong
Copy link
Author

@wmdietl Hi Werner, can you take a look at this PR? I am not sure how to change the downstream tasks to pass all the checks. It seems that some inference failed.

@wmdietl
Copy link
Member

wmdietl commented Aug 31, 2023

Thanks for working on this!
I would suggest splitting this up into multiple PRs. opprop/cf is currently on Version 3.28.0-eisop1. Make a separate PR for each EISOP release since then and make sure that each upgrade individually works. This will make it easier to see at what point this issue is introduced and will make the history in opprop/cf easier to reproduce.
So start with an update to 3.32.0-eisop1 and have corresponding branches in all opprop repositories.
Does that sound like a good approach?

@Ao-senXiong
Copy link
Author

Thanks for working on this! I would suggest splitting this up into multiple PRs. opprop/cf is currently on Version 3.28.0-eisop1. Make a separate PR for each EISOP release since then and make sure that each upgrade individually works. This will make it easier to see at what point this issue is introduced and will make the history in opprop/cf easier to reproduce. So start with an update to 3.32.0-eisop1 and have corresponding branches in all opprop repositories. Does that sound like a good approach?

OK, sounds good. Thanks for the advice.

@Ao-senXiong Ao-senXiong marked this pull request as draft August 31, 2023 20:15
@Ao-senXiong
Copy link
Author

Close as there is a new PR #435.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants