Update to EISOP 3.39-eisop1 from 3.34-eisop1 #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmdietl
requested changes
Apr 6, 2024
| Tree varTree, | ||
| ExpressionTree valueExp, | ||
| @CompilerMessageKey String errorKey, | ||
| Object... extraArgs) { | ||
| if (!validateTypeOf(varTree)) { | ||
| return; | ||
| return true; |
There was a problem hiding this comment.
Why true if the tree isn't valid?
There was a problem hiding this comment.
There was a problem hiding this comment.
That seems wrong over there, too, doesn't it? Let's clean this up in separate PRs.
| @@ -583,7 +594,7 @@ protected void commonAssignmentCheck( | |||
| mono.getCanonicalName(), | |||
| mono.getCanonicalName(), | |||
| valueType.toString()); | |||
| return; | |||
| return true; | |||
There was a problem hiding this comment.
The true is again confusing. Can you add a comment that clarifies?
There was a problem hiding this comment.
Oh, sorry, this one should be return false because of the check fails. And the code here is outdate with super method and should be updated in a seperate PR. @wmdietl I think I will update the copied code after this update.
Co-authored-by: Werner Dietl <wdietl@gmail.com>
wmdietl
reviewed
Apr 7, 2024
| @@ -159,7 +159,7 @@ public void matchAndReplacePrimary(final AnnotatedTypeMirror typeUse, final Anno | |||
| } | |||
|
|
|||
| @Override | |||
| protected String defaultErrorMessage(org.checkerframework.framework.type.AnnotatedTypeMirror type1, org.checkerframework.framework.type.AnnotatedTypeMirror type2, Void aVoid) { | |||
| public String defaultErrorMessage(org.checkerframework.framework.type.AnnotatedTypeMirror type1, org.checkerframework.framework.type.AnnotatedTypeMirror type2, Void aVoid) { | |||
There was a problem hiding this comment.
In a separate PR, look why this uses the fully-qualified name. The method before uses just ATM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this get merged, we can close #413.
PICO's change will be pull in gradually after this change.