Merge pull request #158 from thinkAfCod/fix_init_throw

fix: beacon fetcher test case
optimism-java · Apr 21, 2024 · 6b0633e · 6b0633e
2 parents a9eb615 + 7063cc4
commit 6b0633e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/hildr-node/src/main/java/io/optimism/l1/BeaconBlobFetcher.java b/hildr-node/src/main/java/io/optimism/l1/BeaconBlobFetcher.java
@@ -152,7 +152,6 @@ public List<BlobSidecar> getBlobSidecards(String blockId, final List<BigInteger>
                     blockId,
                     indices);
         }
-        List<BlobSidecar> blobSiders = res.getData();
 
         return res.getData();
     }

diff --git a/hildr-node/src/test/java/io/optimism/l1/BeaconBlobFetcherTest.java b/hildr-node/src/test/java/io/optimism/l1/BeaconBlobFetcherTest.java
@@ -31,7 +31,7 @@ static void setUp() {
         if (!TestConstants.isConfiguredApiKeyEnv) {
             return;
         }
-        fetcher = new BeaconBlobFetcher(config.l1BeaconUrl());
+        fetcher = new BeaconBlobFetcher(config.l1BeaconUrl(), config.l1BeaconArchiverUrl());
     }
 
     @Test
@@ -57,10 +57,9 @@ void getBlobSidecardsAlreadyPrune() {
         if (!TestConstants.isConfiguredApiKeyEnv) {
             return;
         }
-        var blobFetcher = new BeaconBlobFetcher(config.l1BeaconUrl(), config.l1BeaconArchiverUrl());
-        BigInteger slotFromTime = blobFetcher.getSlotFromTime(BigInteger.valueOf(1708659300L));
-        List<BlobSidecar> blobSidecards = blobFetcher.getBlobSidecards(slotFromTime.toString(), null);
-        assertTrue(blobSidecards != null && blobSidecards.size() > 0);
+        BigInteger slotFromTime = fetcher.getSlotFromTime(BigInteger.valueOf(1708659300L));
+        List<BlobSidecar> blobSidecards = fetcher.getBlobSidecards(slotFromTime.toString(), null);
+        assertTrue(blobSidecards != null && !blobSidecards.isEmpty());
     }
 
     @Test