Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logic of BatcherSubmitter #37

Merged
merged 1 commit into from
Aug 10, 2023
Merged

logic of BatcherSubmitter #37

merged 1 commit into from
Aug 10, 2023

Conversation

thinkAfCod
Copy link
Collaborator

#36

GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
hildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java Outdated
l2Client.ethGetBlockByNumber(DefaultBlockParameter.valueOf(number), true);
EthBlock.Block block;
try (var scope = new StructuredTaskScope.ShutdownOnFailure()) {
var blockFur = scope.fork(ethBlockRequest::send);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blockFur这个缩写不对吧

@thinkAfCod thinkAfCod force-pushed the batcher branch 8 times, most recently from 0a24d2f to 9077af1 Compare August 9, 2023 01:59
@GrapeBaBa GrapeBaBa merged commit 8776142 into optimism-java:main Aug 10, 2023
1 check passed
@thinkAfCod thinkAfCod mentioned this pull request Aug 11, 2023
Merged
@thinkAfCod thinkAfCod deleted the batcher branch August 16, 2023 08:50
@thinkAfCod thinkAfCod mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrapeBaBa GrapeBaBa GrapeBaBa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkAfCod @GrapeBaBa