Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Setup initial hardhat deployments #424

Open
wants to merge 5 commits into
base: build/hardhat-compile
Choose a base branch
from
Open

Build: Setup initial hardhat deployments #424

wants to merge 5 commits into from

Conversation

CruzMolina
Copy link
Contributor

@CruzMolina CruzMolina commented Jun 5, 2021 •
edited
Loading

  • style: alphabetize hardhat config keys
  • build: add @nomiclabs/hardhat-ethers @nomiclabs/hardhat-waffle & ethereum-waffle as devDependencies
  • build: configure hardhat config for deployments
  • build: port truffle migrations to hardhat deployment script, update npm deployment scripts
  • build: use dotenv/config for hardhat env vars

antoncoding
antoncoding approved these changes Jun 6, 2021
View reviewed changes
Copy link
Contributor

@antoncoding antoncoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, glad to see us moving to hardhat.
Do u want to convert the tests in the build/hardhat-compile branch too?

hardhat.config.ts Outdated Show resolved Hide resolved
hardhat.config.ts Outdated Show resolved Hide resolved
@CruzMolina
Copy link
Contributor Author

@antoncoding Planning to port over the tests... at some point 😂. For now this PR is intended to switch over migrations to deployments in a non-breaking way.

@haythemsellami
Copy link
Member

Do not merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoncoding antoncoding antoncoding approved these changes

@aparnakr aparnakr Awaiting requested review from aparnakr

@haythemsellami haythemsellami Awaiting requested review from haythemsellami

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CruzMolina @haythemsellami @antoncoding