Fixed windows log path issue

[lu-ohai]

Fixed windows log path issue

• log_artifact

• log_artifacts

[github-actions]

📌 Overall coverage:

No success to gather report. 😿

[github-actions]

📌 Overall coverage:

No success to gather report. 😿

[github-actions]

📌 Overall coverage:

[github-actions]

📌 Overall coverage:

No success to gather report. 😿

[github-actions]

📌 Overall coverage:

No success to gather report. 😿

[github-actions]

📌 Overall coverage:

[github-actions]

📌 Overall coverage:

No success to gather report. 😿

[github-actions]

📌 Overall coverage:

No success to gather report. 😿

[github-actions]

📌 Overall coverage:

[mayoor]

Hey @lu-ohai , can you also add a test case for

local path = "c:\\Users\\testuser\\my datat\\test.txt" ?

[lu-ohai]

Hey @lu-ohai , can you also add a test case for

local path = "c:\\Users\\testuser\\my datat\\test.txt" ?

@mayoor Seems like os.path.basename works differently on Windows and Linux. Windows uses backslash and slash as os.sep while Linux only uses slash.

So os.path.basename("c:\\Users\\testuser\\my datat\\test.txt") will give you test.txt on Windows while give you "c:\\Users\\testuser\\my datat\\test.txt" on linux. For paths with slash, like os.path.basename("my/local/path/my_file.txt"), Windows will also recognize it and give you the correct result my_file.txt.

The test will not pass since we're using ubuntu-latest for test running. Should we also have Windows instance for testing?

[mayoor]

Right, the base name will do the right thing depending on the platform. On a second thought, it might not yield anything by having this test case. The place that matters is how we concatenate, which is covered by the test cases that are already in there. Thanks for taking time checking.

Right thing to do will be to run the test cases on the windows machine as well. We will check that for later.

[mayoor]

Looks good to me!