Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dns_label documentation #354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix dns_label documentation #354

wants to merge 1 commit into from

Conversation

jhult
Copy link
Contributor

@jhult jhult commented Jun 4, 2021

Fix example which contained a dash (-) which is not an alphanumeric character.

Fix example which contained a dash (`-`) which is not an alphanumeric character.
@jodoglevy
Copy link
Member

@jhult thanks for the pull request - however, isn't - a valid character in a domain name?

@jhult
Copy link
Contributor Author

jhult commented Jun 14, 2021

@jodoglevy,

It may be valid, but using a dash (-) with this API call doesn't actually seem to work for me...

@jodoglevy
Copy link
Member

@jhult thanks. This is a generated file, so we can't change it directly (or the changes will be overwritten with the old content upon next generation) -- the source of this doc string internally in OCI needs to be updated and then it would get reflected in the OCI SDKs.

I'll reach out to the OCI Networking / Docs teams about getting this doc string updated. Thanks for pointing out the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants