StackdriverJsonLayout timestampNanos timestampSeconds support #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangain
reviewed
Oct 9, 2024
|
Thanks for commenting. I've added logic to parse seconds and nanos, and a test. |
orangain
reviewed
Oct 16, 2024
src/test/kotlin/io/github/orangain/prettyjsonlog/logentry/TimestampTest.kt
Show resolved
Hide resolved
LeeGilbert
changed the title
LeeGilbert
force-pushed
the
StackdriverJsonLayout-patch-1
branch
from
c1d0dcf
to
4d547b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StackdriverJsonLayout in spring-cloud-gcp-logging writes a nano timestamp keyed by "timestampNanos".
Add "timestampNanos" to list of timestampKeys in Timestamp.kt
to fix null appearing in Console and fully support Google Cloud Logging console format with Logback.