fix: ci and linters

.github/workflows/release.yml

@@ -21,15 +21,17 @@ jobs:
       TOKEN: ${{ secrets.CHANGELOG_PAT }}
 
   golang-ci-lint:
+    needs: [pre-check]
     name: "GolangCI Lint"
     uses: orange-cloudavenue/workflows/.github/workflows/go_golangci-lint.yml@main
 
   tests:
+    needs: [pre-check]
     name: "Unit Tests"
     uses: orange-cloudavenue/workflows/.github/workflows/go_unit-test.yml@main
 
   tag:
-    needs: [pre-check]
+    needs: [golang-ci-lint, tests]
     name: Tag
     uses: orange-cloudavenue/workflows/.github/workflows/tag_create-tag.yml@main
     with:

boolplanmodifier/base_default_func.go

@@ -5,8 +5,9 @@ import (
 	"context"
 
 	"github.com/hashicorp/terraform-plugin-framework/diag"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/types"
+
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 )
 
 // DefaultFunc is a function that can be used to set a default value for a

boolplanmodifier/default_env_var_test.go

@@ -6,9 +6,11 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/hashicorp/terraform-plugin-framework/types"
 
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/orange-cloudavenue/terraform-plugin-framework-planmodifiers/boolplanmodifier"
 )
 
@@ -81,7 +83,6 @@ func TestDefaultEnvVarModifierPlanModifyBool(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		name, testCase := name, testCase
 		// set environnement variable
 		t.Setenv(envVarName, "true")
 

boolplanmodifier/default_func_test.go

@@ -6,9 +6,11 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/hashicorp/terraform-plugin-framework/types"
 
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/orange-cloudavenue/terraform-plugin-framework-planmodifiers/boolplanmodifier"
 )
 
@@ -78,8 +80,6 @@ func TestDefaultFuncModifierPlanModifyBool(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		name, testCase := name, testCase
-
 		t.Run(name, func(t *testing.T) {
 			// t.Parallel()
 

boolplanmodifier/default_test.go

@@ -6,9 +6,11 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/hashicorp/terraform-plugin-framework/types"
 
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/orange-cloudavenue/terraform-plugin-framework-planmodifiers/boolplanmodifier"
 )
 
@@ -78,8 +80,6 @@ func TestDefaultModifierPlanModifyBool(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		name, testCase := name, testCase
-
 		t.Run(name, func(t *testing.T) {
 			// t.Parallel()
 

boolplanmodifier/require_replace_if_bool.go

@@ -5,9 +5,10 @@ import (
 	"fmt"
 
 	"github.com/hashicorp/terraform-plugin-framework/path"
+	"github.com/hashicorp/terraform-plugin-framework/types"
+
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/boolplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
-	"github.com/hashicorp/terraform-plugin-framework/types"
 )
 
 /*

boolplanmodifier/require_replace_if_bool_test.go

@@ -5,11 +5,14 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
+
 	"github.com/hashicorp/terraform-plugin-framework/path"
 	"github.com/hashicorp/terraform-plugin-framework/provider/schema"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/tfsdk"
 	"github.com/hashicorp/terraform-plugin-framework/types"
+
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/hashicorp/terraform-plugin-go/tftypes"
 
 	"github.com/orange-cloudavenue/terraform-plugin-framework-planmodifiers/boolplanmodifier"
@@ -134,8 +137,6 @@ func Test_requireReplaceIfBool(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		name, testCase := name, testCase
-
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

int64planmodifier/base_default_func.go

@@ -5,8 +5,9 @@ import (
 	"context"
 
 	"github.com/hashicorp/terraform-plugin-framework/diag"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/types/basetypes"
+
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 )
 
 // DefaultFunc is a function that can be used to set a default value for a

int64planmodifier/default_env_var_test.go

@@ -6,9 +6,11 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/hashicorp/terraform-plugin-framework/types"
 
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/orange-cloudavenue/terraform-plugin-framework-planmodifiers/int64planmodifier"
 )
 
@@ -81,7 +83,6 @@ func TestDefaultEnvVarModifierPlanModifyInt64(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		name, testCase := name, testCase
 		// set environnement variable
 		t.Setenv(envVarName, "123")
 

int64planmodifier/default_func_test.go

@@ -6,9 +6,11 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/hashicorp/terraform-plugin-framework/types"
 
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/orange-cloudavenue/terraform-plugin-framework-planmodifiers/int64planmodifier"
 )
 
@@ -78,8 +80,6 @@ func TestDefaultFuncModifierPlanModifyInt64(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		name, testCase := name, testCase
-
 		t.Run(name, func(t *testing.T) {
 			// t.Parallel()
 

int64planmodifier/default_test.go

@@ -6,9 +6,11 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/hashicorp/terraform-plugin-framework/types"
 
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/orange-cloudavenue/terraform-plugin-framework-planmodifiers/int64planmodifier"
 )
 
@@ -78,8 +80,6 @@ func TestDefaultModifierPlanModifyInt64(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		name, testCase := name, testCase
-
 		t.Run(name, func(t *testing.T) {
 			// t.Parallel()
 

int64planmodifier/require_replace_if_bool.go

@@ -5,9 +5,10 @@ import (
 	"fmt"
 
 	"github.com/hashicorp/terraform-plugin-framework/path"
+	"github.com/hashicorp/terraform-plugin-framework/types"
+
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/int64planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
-	"github.com/hashicorp/terraform-plugin-framework/types"
 )
 
 /*

int64planmodifier/require_replace_if_bool_test.go

@@ -5,11 +5,14 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
+
 	"github.com/hashicorp/terraform-plugin-framework/path"
 	"github.com/hashicorp/terraform-plugin-framework/provider/schema"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/tfsdk"
 	"github.com/hashicorp/terraform-plugin-framework/types"
+
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/hashicorp/terraform-plugin-go/tftypes"
 
 	"github.com/orange-cloudavenue/terraform-plugin-framework-planmodifiers/int64planmodifier"
@@ -134,8 +137,6 @@ func Test_requireReplaceIfBool(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		name, testCase := name, testCase
-
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

stringplanmodifier/base_default_func.go

@@ -5,8 +5,9 @@ import (
 	"context"
 
 	"github.com/hashicorp/terraform-plugin-framework/diag"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/types"
+
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 )
 
 // DefaultFunc is a function that can be used to set a default value for a

stringplanmodifier/base_string_change.go

@@ -5,8 +5,9 @@ import (
 	"context"
 
 	"github.com/hashicorp/terraform-plugin-framework/diag"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/types"
+
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 )
 
 // StringChangeFunc is a function that can be used to change a string value.
@@ -24,7 +25,7 @@ type StringChangeFuncResponse struct {
 
 // setStringChangeFunc
 //
-// Change the value of the strinf
+// Change the value of the strinf.
 func setChangeStringFunc(f StringChangeFunc, description, markdownDescription string) planmodifier.String {
 	return stringChangeFuncPlanModifier{
 		f:                   f,

stringplanmodifier/default_empty_string_test.go

@@ -6,9 +6,11 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/hashicorp/terraform-plugin-framework/types"
 
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/orange-cloudavenue/terraform-plugin-framework-planmodifiers/stringplanmodifier"
 )
 
@@ -78,8 +80,6 @@ func TestDefaultModifierPlanModifyEmptyString(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		name, testCase := name, testCase
-
 		t.Run(name, func(t *testing.T) {
 			// t.Parallel()
 

stringplanmodifier/default_env_var_test.go

@@ -6,9 +6,11 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/hashicorp/terraform-plugin-framework/types"
 
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/orange-cloudavenue/terraform-plugin-framework-planmodifiers/stringplanmodifier"
 )
 
@@ -81,7 +83,6 @@ func TestDefaultEnvVarModifierPlanModifyString(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		name, testCase := name, testCase
 		// set environnement variable
 		t.Setenv(envVarName, envValue)
 

stringplanmodifier/default_func_test.go

@@ -7,9 +7,11 @@ import (
 
 	"github.com/dchest/uniuri"
 	"github.com/google/go-cmp/cmp"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/hashicorp/terraform-plugin-framework/types"
 
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/orange-cloudavenue/terraform-plugin-framework-planmodifiers/stringplanmodifier"
 )
 
@@ -79,8 +81,6 @@ func TestDefaultFuncModifierPlanModifyString(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		name, testCase := name, testCase
-
 		t.Run(name, func(t *testing.T) {
 			// t.Parallel()
 

stringplanmodifier/default_test.go

@@ -7,9 +7,11 @@ import (
 
 	"github.com/dchest/uniuri"
 	"github.com/google/go-cmp/cmp"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/hashicorp/terraform-plugin-framework/types"
 
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+
 	"github.com/orange-cloudavenue/terraform-plugin-framework-planmodifiers/stringplanmodifier"
 )
 
@@ -79,8 +81,6 @@ func TestDefaultModifierPlanModifyString(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		name, testCase := name, testCase
-
 		t.Run(name, func(t *testing.T) {
 			// t.Parallel()
 

stringplanmodifier/require_replace_if_bool.go

@@ -5,9 +5,10 @@ import (
 	"fmt"
 
 	"github.com/hashicorp/terraform-plugin-framework/path"
+	"github.com/hashicorp/terraform-plugin-framework/types"
+
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
-	"github.com/hashicorp/terraform-plugin-framework/types"
 )
 
 /*

stringplanmodifier/to_lower.go

@@ -5,8 +5,9 @@ import (
 	"context"
 	"strings"
 
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/types"
+
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 )
 
 func ToLower() planmodifier.String {