docs: resolves markdown error and misspells in "pushing and pulling artifacts" section #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Singh <116020663+1Shubham7@users.noreply.github.com>
1Shubham7
requested review from
asmitbm,
FeynmanZhou,
sajayantony,
shizhMSFT,
SteveLasker and
vsoch
as code owners
Signed-off-by: Shubham Singh <116020663+1Shubham7@users.noreply.github.com>
Signed-off-by: Shubham Singh <116020663+1Shubham7@users.noreply.github.com>
|
I made a mistake in the second commit, I misunderstood something, sorry for that, corrected it in the next commit. |
asmitbm
requested changes
Jul 20, 2023
Co-authored-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: Shubham Singh <116020663+1Shubham7@users.noreply.github.com>
FeynmanZhou
reviewed
Jul 24, 2023
Co-authored-by: Feynman Zhou <feynman@kubesphere.io> Signed-off-by: Shubham Singh <116020663+1Shubham7@users.noreply.github.com>
|
noted @FeynmanZhou, thanks for helping. |
sajayantony
reviewed
Jul 24, 2023
Co-authored-by: Sajay Antony <sajaya@microsoft.com> Signed-off-by: Shubham Singh <116020663+1Shubham7@users.noreply.github.com>
asmitbm
requested changes
Jul 27, 2023
Co-authored-by: Asmit Malakannawar <81866614+asmitbm@users.noreply.github.com> Signed-off-by: Shubham Singh <116020663+1Shubham7@users.noreply.github.com>
Co-authored-by: Asmit Malakannawar <81866614+asmitbm@users.noreply.github.com> Signed-off-by: Shubham Singh <116020663+1Shubham7@users.noreply.github.com>
|
added the changes @asmitbm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #228
Resolves the 3 errors described in issue #228.