Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref types #240

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Ref types #240

merged 3 commits into from
Aug 18, 2023

Conversation

sajayantony
Copy link
Contributor

@sajayantony sajayantony commented Aug 5, 2023

This PR is based of the the artifact concept and will rebase on #238 is completed.

Preview link - https://deploy-preview-240--oras-project.netlify.app/docs/concepts/reftypes

docs/concepts/reftypes.mdx Outdated Show resolved Hide resolved
docs/concepts/reftypes.mdx Outdated Show resolved Hide resolved
docs/concepts/reftypes.mdx Outdated Show resolved Hide resolved
docs/concepts/reftypes.mdx Outdated Show resolved Hide resolved
docs/concepts/reftypes.mdx Show resolved Hide resolved
docs/concepts/reftypes.mdx Outdated Show resolved Hide resolved
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice conceptual doc! Thank you @sajayantony for writing it. Just a few suggestions. PTAL

@FeynmanZhou
Copy link
Member

cc @oras-project/oras-cli for review

docs/concepts/reftypes.mdx Outdated Show resolved Hide resolved
docs/concepts/reftypes.mdx Outdated Show resolved Hide resolved
docs/concepts/reftypes.mdx Outdated Show resolved Hide resolved
docs/concepts/reftypes.mdx Outdated Show resolved Hide resolved
Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
docs/concepts/reftypes.mdx Outdated Show resolved Hide resolved
docs/concepts/reftypes.mdx Outdated Show resolved Hide resolved
sajayantony and others added 2 commits August 16, 2023 11:49
Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajayantony sajayantony merged commit 14180ff into oras-project:main Aug 18, 2023
6 checks passed
@sajayantony sajayantony deleted the references branch August 18, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants