Recommend sembr for docs #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajayantony
requested review from
asmitbm,
FeynmanZhou,
shizhMSFT,
SteveLasker and
vsoch
as code owners
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
|
@TerryHowe - Do you think we should avoid line breaks at 80 and just do one line a sentence. I couldn't understand if sembr recommends the line breaks or one new sentence per line or both. |
|
I don't need line breaks at 80, but I could go either way on that. |
|
On second thought, I'd prefer we didn't mandate 80 chars. I'd be breaking that all the time. |
|
Agreed. I also find holding the 80 char limit hard :) |
|
Does this need to be a draft still? |
|
Update review status @TerryHowe |
|
@shizhMSFT @FeynmanZhou any concerns? |
TerryHowe
pushed a commit
to TerryHowe/oras-www
that referenced
this pull request
Jul 21, 2024
Preview link - https://deploy-preview-249--oras-project.netlify.app/docs/community/contributing_guide#development-environment-setup Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview link - https://deploy-preview-249--oras-project.netlify.app/docs/community/contributing_guide#development-environment-setup