Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unneeded edit url link configuration #340

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

TerryHowe
Copy link
Member

I'm not sure why this configuration was added.

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
sajayantony
sajayantony previously approved these changes Jun 7, 2024
shizhMSFT
shizhMSFT previously approved these changes Jun 7, 2024
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Terry Howe <tlhowe@amazon.com>
@TerryHowe TerryHowe dismissed stale reviews from shizhMSFT and sajayantony via 6ed4453 June 7, 2024 13:04
@asmitbm
Copy link
Member

asmitbm commented Jun 9, 2024

I'm not sure why this configuration was added.

This config was added because, while I was working on the website, ORAS didn't need the documentation to be updated for every new version. So, we added the fix label to allow manual version changes.

Copy link
Member

@asmitbm asmitbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@TerryHowe TerryHowe merged commit 13fc211 into oras-project:main Jun 9, 2024
6 checks passed
TerryHowe pushed a commit to TerryHowe/oras-www that referenced this pull request Jul 21, 2024
I'm not sure why this configuration was added.

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Terry Howe <tlhowe@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants