Fix ticket #96 add Extent to CRS #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @mukoki |
|
Quite old one... should still be OK. It would probably need more tests though. I think that merging it just before a release does not make much sense as it is not sufficient to solve concrete problems. I would recommand to merge it, test it, try to add new capabilities using the new methods then release. |
|
Thanks I'll add it to the 1.7 road map |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition to add extent to CRS.
As Extent is an interface, I just implemented it in CoordinateReferenceSystem. Default implementation always return true. GeodeticCRS implementation makes it possible to define Extent from projected coordinates or from geographic coordinates (referring to this CRS's Datum). In the later case, geographic coordinates are transformed into this CRS's coordinates.
Needs more tests.