Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drivers documentation #1133

Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from

Conversation

gpetit
Copy link
Contributor

@gpetit gpetit commented Oct 12, 2020

Update the drivers documentation

  • Add ASCREAD
  • Add deleteTable parameter when needed
  • Update fileEncoding parameter when needed
  • Add compressed file when needed
  • Other improvements (PK added for .shp and .dbf, typo, visual rendering of the documentation, ...)

Linked with #1099

@gpetit gpetit added the Doc Documentation label Oct 12, 2020
Copy link
Member

@ebocher ebocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

docs/dev/ASCRead.md Outdated Show resolved Hide resolved
docs/dev/ASCRead.md Outdated Show resolved Hide resolved
docs/dev/ASCRead.md Outdated Show resolved Hide resolved
@gpetit
Copy link
Contributor Author

gpetit commented Nov 27, 2020

Can we merge ?

@ebocher
Copy link
Member

ebocher commented Nov 27, 2020

We must check H2GIS version before merging because some fixes have been done on master and others on dev branch

@gpetit
Copy link
Contributor Author

gpetit commented Nov 27, 2020

Ok no problem

GeoJsonWrite(VARCHAR path, VARCHAR tableName, VARCHAR fileEncoding);
GeoJsonWrite(VARCHAR path, VARCHAR tableName,
BOOLEAN deleteTable);
GeoJsonWrite(VARCHAR path, VARCHAR tableName,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encoding has been removed
The signatures are now

GeoJsonWrite(VARCHAR path, VARCHAR tableName);
GeoJsonWrite(VARCHAR path, VARCHAR tableName,
BOOLEAN deleteTable);

#### 3. Case with `fileEncoding`

{% highlight mysql %}
CALL GeoJsonWrite('/home/user/test.geojson', 'TEST', 'utf-8');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsupported because json must be in utf-8

{% highlight mysql %}
CALL GeoJsonWrite('/home/gpetit/test.geojson', 'TEST', true);
-- or
CALL GeoJsonWrite('/home/user/test.geojson', 'TEST', 'utf-8', true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed

{% highlight mysql %}
CALL JsonWrite('/home/gpetit/test.json', 'TEST', true);
-- or
CALL JsonWrite('/home/user/test.json', 'TEST', 'utf-8', true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as for geojson. Encoding is not supported any more.

@ebocher
Copy link
Member

ebocher commented Feb 16, 2021

This doc can be updated with the issues :

#1163
#1139
#989
#1222

@ebocher
Copy link
Member

ebocher commented Dec 1, 2021

and
#1152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants