Fixed missing bs in popover data attributes
#2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
bsin popover data attributes.In addition, I will explain why
triggerwas changed toclick.In the current state, the value from the data attribute is not used and the behavior is exactly like
click, that is, it opens on the first click, and closes on the second click.If use
focus, then something strange turns out in general - it opens on the first click, and you can close it only if you click the second time and additionally again in another place, although in theory it should close on the second click in another place.@tabuna Do you have a problem with trigger
focusand how should I proceed?