Replies: 1 comment 6 replies
-
@VKniaz Thank you for bringing this up.
IMO, to preserve simplicity of content authoring we should choose only one approach and agree it should be standard. Let's analyse your proposal. <div class="merch-card plans secure">
<div>
<div data-valign="middle">#EDCC2D, #000000</div>
<div data-valign="middle"></div>
</div>
<div>
<div data-valign="middle">
<h3 id="acrobat-pro">Acrobat Pro</h3>
<p>
Access advanced PDF and form creation, editing, and protection features
tailored to enterprise security and compliance requirements.
</p>
<p>title=Select a quantity_min=1_max=3_step=1</p> <!-- named params -->
<p>
<strong><a href="...">CTA {{buy-now}}</a></strong>
</p>
</div>
</div>
</div> To parse quantity selector params out of it, you code needs to find a first This sounds three times more complex than just positional lookup, proposed by @yesil, and real benefits of such complication are unclear to me. So, I'd vote to keep simple positional lookup, already widely used in Milo, instead of introducing the need of manual creation of strings in custom format to pack sets of key-value pairs. An inconsistency note: String format proposed in this article differs from the format in the sample Word doc. An example of positional params in the catalog fragment, demoed by @yesil: https://main--cc--adobecom.hlx.page/drafts/ilyas/fragments/catalog:
|
Beta Was this translation helpful? Give feedback.
-
Proposal for New Quantity Selector Pattern in Merch Cards
Dear Team,
I am reaching out to discuss a potential enhancement to our merch cards, as detailed in the JIRA ticket MWPW-135163(https://jira.corp.adobe.com/browse/MWPW-135163)]
The proposed pattern for this feature is [title:_min:_max:_step:].
document example:
https://adobe.sharepoint.com/:w:/r/sites/adobecom/_layouts/15/Doc.aspx?sourcedoc=%7BAA370755-2294-4115-97F1-367C5CE175F6%7D&file=Document6.docx&action=default&mo
link:
https://mwpw-135163--milo--vkniaz.hlx.page/drafts/vkniaziev/document6
I would greatly appreciate your input regarding this proposed change. Specifically, I am interested in any concerns or objections you might have about introducing this new pattern.
Beta Was this translation helpful? Give feedback.
All reactions