Disregard 'Ready for Stage' label if new commit pushed

[3ch023]

Just wanted to check what do you think about this additional restriction idea.

Suggestion: any new push on the feature PR will remove the 'Ready for Stage' label if it was present.

Reason:
If QA added 'Ready for Stage' and after that Dev committed some new code, the feature must be re-validated.
We could automate the 'Ready for Stage' label removing for such cases.

Not sure how often it happens though, so asking the community if its worse the effort to contribute.

[mokimo]

There's a couple of corner cases I could think of, where we'd falsely remove the label:

• Rebasing or merging stage into the branch
• Updating some unit tests//technical changes, minor changes in readme's or comments.
• Fixing some linting issues (albeit, this should have been done before Ready for Stage ever got added)

In theory, after the QA adds Ready for Stage the PR shouldn't ever be touched again. In practice, I'd agree with you Mariia and commits do happen after sign off.

It's easy to add and the zero impact workflow is already adding/removing labels.

I'm torn about it, but I personally don't want to add QA/Dev overhead from a process perspective unless this leads to issues - but happy to implement this if the community wants this

[3ch023]

I agree with your concerns, it will certainly add more bureaucracy and now that I think about it.. probably not worth it.