You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
tl;dr; PRs finish roughly ~30 seconds faster as of yesterday.
When you create a PR, it's highly productive to be able to find out if it failed/passed as soon as possible. Otherwise, the mind wanders and you might be too disengaged or bored to finish what wasn't working. And if it did pass, you'll want to see the Preview URLs sooner from the PR Review Companion.
Basically, we use actions/cache to cache the whole node_modules between runs. If yarn.lock hasn't changed, node_modules/ shouldn't change. Being able to skip the yarn install step can save you roughly 30 seconds because retrieving from cache is 1-4seconds.
The revelation was that a PR can't re-use a cached thing unless it was previously stored on the main branch (or its own branch when 1 PR is multiple commits). So now, after your PR is merged, the CI tests run one more time, in the background once it's been merged in main.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
tl;dr; PRs finish roughly ~30 seconds faster as of yesterday.
When you create a PR, it's highly productive to be able to find out if it failed/passed as soon as possible. Otherwise, the mind wanders and you might be too disengaged or bored to finish what wasn't working. And if it did pass, you'll want to see the Preview URLs sooner from the PR Review Companion.
Here's the original issue: mdn/content#8014
Here's the solution: mdn/content#8066
Basically, we use
actions/cache
to cache the wholenode_modules
between runs. Ifyarn.lock
hasn't changed,node_modules/
shouldn't change. Being able to skip theyarn install
step can save you roughly 30 seconds because retrieving from cache is 1-4seconds.The revelation was that a PR can't re-use a cached thing unless it was previously stored on the
main
branch (or its own branch when 1 PR is multiple commits). So now, after your PR is merged, the CI tests run one more time, in the background once it's been merged inmain
.Beta Was this translation helpful? Give feedback.
All reactions