In node v18 and above, server is getting closed quickly without honoring the keep-alive timeouts

[kumarrishav]

In my unit tests, I am seeing a behavior in node v18 and above that, Server is getting closed quickly after calling server.close() without honoring the keep-alive timeouts. Hence, new request is failing. Expectation: New request shouldn't fail as it should use the existing open connection unless closed explicitly.

It works fine with Node v16.

Only difference in code while running node v16 and node 18 - I have @SECLEVEL=0 in ciphers for node 18. Not sure if it's related.

Error: read ECONNRESET
    at TLSWrap.onStreamRead [as _originalOnread] (node:internal/stream_base_commons:217:20)
    at TLSWrap.<anonymous> (/<private_code path>/node_modules/async-listener/glue.js:188:31)
    at TLSWrap.callbackTrampoline (node:internal/async_hooks:128:17) {
  errno: -54,
  code: 'ECONNRESET',
  syscall: 'read'
}

I will try to get a sample code to reproduce. Just wanted to check if anyone came across this

[kumarrishav]

any insights here @bnoordhuis ? Something you came across.

I read few threads where it talks about race condition. But in my Unit test, i don't expect that to happen. Also, keepalive timeout is 20 secs which is more than enough time.

1. Client => Server (with keep-alive as 20 sec)
2. (SIGINT => server.close)
3. Client => Server => It fails with ECONNRESET. I expected it to be statusCode 200.
   and After this Server is supposed to send Connection:close header so that next request fails.

[kumarrishav]

Steps to reproduce:

code: test.js (with client and server)

(async function x(){
const http = require('http');

function delay(ms) {
    return new Promise(resolve => setTimeout(resolve, ms));
}

// server
const server = http.createServer((req, res) => {
    res.writeHead(200);
    res.end('hello World!');
});

server.keepAliveTimeout = 5000;

const port = 3000;
server.listen(port, () => {
  console.log(`Server running at http://localhost:${port}/`);
});

// client
const options= {
    keepAlive: true
}
const agent = new http.Agent(options);

const makeServerRequest = async function() {
    return new Promise((resolve, reject) => {
        http.request({
            method: 'GET',
            protocol: 'http:',
            hostname: '127.0.0.1',
            port: 3000,
            agent: agent
        }, function (res) {
            res.on('data',()=>{});
            res.on('end',() => {
                console.log(res.headers,res.statusCode, res.req.reusedSocket);
                resolve({headers: res.headers, statusCode: res.statusCode});
            });
        })
        .on('error', (e) => {
            console.log('error', e)
            reject(e);
        })
        .end();
    });
};

await makeServerRequest();
await makeServerRequest();
await makeServerRequest();

await delay(3000);

server.close();

await makeServerRequest();
await makeServerRequest();

}());

Behaviour in Node V16 (v16.20.2)

• No error and status 200 even after server.close because of reusing existing connection.

Behaviour in Node V18 (v18.20.0)

• Error after server.close

[kumarrishav]

After digging more, I found that this behavior started in node v18.19.0 .

It worked fine until v18.18.2

[kumarrishav]

further discussion on #52330

[kumarrishav]

fixed in #52336