submission functionality?

[alan-stokes]

is this implemented anywhere yet?
do we have an idea of how a proposal is submitted?

[pahjbo]

It is not yet implemented anywhere in the UI - there is a unit test in the api service that attempts to exercise the API for the PI all the way to submission UseCasePiTest

There is a similar one for what a member of the time allocation committee might do post submission

[AllanEngland]

I've created a draft pull request to add submission functionality.

At the moment submission correctly duplicates the proposal but erroneously lists it next to the source proposal and allows editing! I'll update the API hide submitted proposals from the search, however, it leaves a question of where and how do we show submitted proposals to the user.

[alan-stokes]

so my two piece. 1. what is the use case for submitted proposals? aka, can the user reopen it, edit and resubmit it? or is it that really once its submitted, its read only? If you open the un-submitted version, and resubmit it, does that produce a second submitted or override the first? (the current implementation would produce a 3rd one and 4th one etc). in NGOT, a re-submitted proposal would override the previous submission, and when viewing the submitted version, everything would be in read only mode.

[alan-stokes]

on more thinking, you could change the icon colour to be more greyed to indicated the read only (if that's they way ya want to go) Id also propose augmenting the proposal title with the submitted time stamp, as that will then make it clear this is a submitted proposal.

[pahjbo]

there is a slight blocker on the current implementation of submission whereby the copied proposal that becomes part of the submitted proposal contains references to objects in the original proposal - the non-copying of references is an intentional part of the VO-DML machinery, but if a reference is also contained then this should be copied - see ivoa/vo-dml#42