table management #8
alan-stokes
started this conversation in
General
Replies: 2 comments 1 reply
-
I agree we need to choose one layout style and use it consistently throughout the app - probably the style Darren has gone with for the technical goals and observations. |
Beta Was this translation helpful? Give feedback.
1 reply
-
I'll look at adding a header to the targets and investigators. Also agree with merging the headers and rows for observations and goals into single files. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I see that whenever there is a table (technicalGoals, Observations) there is a table.row.tsx which only manages the row data, whereas either the list.tsx or another file (goals.tsx for example) manages the header.
Would it not be better to rename the table.row.tsx to something akin to goalTable.tsx (for technical goals) and observationsTable (for observations) which contains at least 2 functions, 1 for the header and 1 for the body. ensuring that changes related to the table are self contained to 1 file and reduces the risk of someone trying to changing one and forgetting about the other?
Id also wonder if wed want the investigators to have a table like format as the observations and technical goals. Because at the moment, there is no header for the investigators, which would be problematic for screen readers for visually impaired people.
same question for the targets.
Beta Was this translation helpful? Give feedback.
All reactions