You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, it looks like FormGroup uses context to consume the isRequired prop from the parent Form component. The isRequired prop also ends up showing up in any child component of FormGroup, like TextInput for example. This is the expected behavior of the isRequired prop, per @jgiardino.
At the moment,FormSelect doesn't do the same thing with context.
This would be a good enhancement to make if we're trying to stay consistent among all form components.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
This issue is an extension to #1397 and PR #2365
Currently, it looks like
FormGroup
uses context to consume theisRequired
prop from the parentForm
component. The isRequired prop also ends up showing up in any child component ofFormGroup
, likeTextInput
for example. This is the expected behavior of the isRequired prop, per @jgiardino.At the moment,
FormSelect
doesn't do the same thing with context.This would be a good enhancement to make if we're trying to stay consistent among all form components.
Beta Was this translation helpful? Give feedback.
All reactions