Retroactively modifiying end valid time not working

[lgrapenthin]

user> (def my-node (crux/start-node {}))
#'user/my-node
user> (crux/submit-tx my-node [[:crux.tx/put
                                {:crux.db/id :test1
                                 :some-data "foo"}]])
#:crux.tx{:tx-id 0, :tx-time #inst "2021-02-28T10:08:52.075-00:00"}
user> (crux/entity-tx (crux/db my-node) :test1)
{:crux.db/id #crux/id "b444ac06613fc8d63795be9ad0beaf55011936ac", :crux.db/content-hash #crux/id "67c1e8cabf01f1d2890f3d8888d1546291196c2a", :crux.db/valid-time #inst "2021-02-28T10:08:52.075-00:00", :crux.tx/tx-time #inst "2021-02-28T10:08:52.075-00:00", :crux.tx/tx-id 0}
user> (crux/submit-tx my-node [[:crux.tx/put
                                {:crux.db/id :test1
                                 :some-data "foo"}
                                #inst"2021-02-28T10:08:52.075-00:00"
                                ;; now invalid one second later
                                #inst"2021-02-28T10:08:53.075-00:00"]])
#:crux.tx{:tx-id 1, :tx-time #inst "2021-02-28T10:09:55.026-00:00"}
user> (crux/q (crux/db my-node)
              '[:find ?elem
                :where [?elem :some-data]])
#{[:test1]}
user> 

[refset]

Hi, this is the expected behaviour. For context you may want to look through #444 and #326

Essentially what happens is that the second transaction "resumes" the history of whatever the previous value would have been, after the new end-valid-time terminates. I think to achieve the behaviour you are looking for, you simply need to add a :crux.tx/delete operation to the transaction:

(crux/submit-tx my-node [[:crux.tx/put
                                {:crux.db/id :test1
                                 :some-data "foo"}
                                #inst"2021-02-28T10:08:52.075-00:00"
                                ;; now invalid one second later
                                #inst"2021-02-28T10:08:53.075-00:00"]
                         [:crux.tx/delete
                                :test1
                                ;; delete from one second later until the end of time
                                #inst"2021-02-28T10:08:53.075-00:00"
                                (Date. Long.MAX_VALUE)]])