fix: Disable dataloader shuffle for classification datamodule (#116)

* fix: Disable dataloader shuffle for classification datamodule * build: Update version, update changelog * fix: Fix multilabel datamodule using train dataset inside validation
orobix · May 17, 2024 · 9dbd1bf · 9dbd1bf
1 parent 5d5dbe6
commit 9dbd1bf
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,12 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+### [2.1.5]
+
+#### Fixed
+
+- Fix classification val_dataloader shuffling data when it shouldn't
+
 ### [2.1.4]
 
 #### Updated

diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "quadra"
-version = "2.1.4"
+version = "2.1.5"
 description = "Deep Learning experiment orchestration library"
 authors = [
 	"Federico Belotti <federico.belotti@orobix.com>",

diff --git a/quadra/__init__.py b/quadra/__init__.py
@@ -1,4 +1,4 @@
-__version__ = "2.1.4"
+__version__ = "2.1.5"
 
 
 def get_version():

diff --git a/quadra/datamodules/classification.py b/quadra/datamodules/classification.py
@@ -384,7 +384,7 @@ def val_dataloader(self) -> DataLoader:
         return DataLoader(
             self.val_dataset,
             batch_size=self.batch_size,
-            shuffle=True,
+            shuffle=False,
             num_workers=self.num_workers,
             drop_last=False,
             pin_memory=True,
@@ -965,9 +965,9 @@ def val_dataloader(self) -> DataLoader:
         if not self.val_dataset_available:
             raise ValueError("Validation dataset is not initialized")
         return DataLoader(
-            self.train_dataset,
+            self.val_dataset,
             batch_size=self.batch_size,
-            shuffle=True,
+            shuffle=False,
             num_workers=self.num_workers,
             drop_last=False,
             pin_memory=True,