Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HRTF panner initialization time by caching the HRIR sphere #375

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

orottier
Copy link
Owner

relates to #371

@orottier
Copy link
Owner Author

/bench

@github-actions
Copy link

Benchmark result:


bench_ctor
  Instructions:             4570535 (+0.244331%)
  L1 Accesses:              6840454 (+0.327392%)
  L2 Accesses:                54322 (-0.007363%)
  RAM Accesses:               61605 (-0.014607%)
  Estimated Cycles:         9268239 (+0.237794%)

bench_sine
  Instructions:            71128271 (+0.079041%)
  L1 Accesses:            103831299 (+0.093548%)
  L2 Accesses:               263756 (+0.131354%)
  RAM Accesses:               62491 (+0.003201%)
  Estimated Cycles:       107337264 (+0.092169%)

bench_sine_gain
  Instructions:            76259990 (+0.098274%)
  L1 Accesses:            111589580 (+0.111790%)
  L2 Accesses:               273312 (+2.411607%)
  RAM Accesses:               62586 (+0.003196%)
  Estimated Cycles:       115146650 (+0.136409%)

bench_sine_gain_delay
  Instructions:           150553109 (+0.064756%)
  L1 Accesses:            211680708 (+0.069852%)
  L2 Accesses:               517839 (+3.403595%)
  RAM Accesses:               64182 (-0.006232%)
  Estimated Cycles:       216516273 (+0.107657%)

bench_buffer_src
  Instructions:            17682514 (+0.306641%)
  L1 Accesses:             25736842 (+0.343850%)
  L2 Accesses:                87474 (+0.448997%)
  RAM Accesses:              100638 (No change)
  Estimated Cycles:        29696542 (+0.304488%)

bench_buffer_src_delay
  Instructions:            90642606 (+0.087668%)
  L1 Accesses:            123974597 (+0.096016%)
  L2 Accesses:               167422 (+3.844985%)
  RAM Accesses:              100774 (-0.002977%)
  Estimated Cycles:       128338797 (+0.116867%)

bench_buffer_src_iir
  Instructions:            41870685 (+0.147133%)
  L1 Accesses:             60984482 (+0.171348%)
  L2 Accesses:                87254 (-0.911909%)
  RAM Accesses:              100844 (-0.005949%)
  Estimated Cycles:        64950292 (+0.154343%)

bench_buffer_src_biquad
  Instructions:            37946268 (+0.268307%)
  L1 Accesses:             53418158 (+0.328475%)
  L2 Accesses:               130076 (-0.033047%)
  RAM Accesses:              100849 (-0.119838%)
  Estimated Cycles:        57598253 (+0.296792%)

bench_stereo_positional
  Instructions:            45808005 (+0.483641%)
  L1 Accesses:             68571171 (+0.428380%)
  L2 Accesses:               349805 (+25.89843%)
  RAM Accesses:              100924 (-0.128644%)
  Estimated Cycles:        73852536 (+0.884822%)

bench_stereo_panning_automation
  Instructions:            32344211 (+0.232715%)
  L1 Accesses:             48391662 (+0.262715%)
  L2 Accesses:               137080 (-0.288050%)
  RAM Accesses:              100746 (-0.121940%)
  Estimated Cycles:        52603172 (+0.229626%)

bench_analyser_node
  Instructions:            39849552 (+0.159224%)
  L1 Accesses:             55841694 (+0.188637%)
  L2 Accesses:               179104 (-0.511043%)
  RAM Accesses:              101402 (+0.012822%)
  Estimated Cycles:        60286284 (+0.167807%)

bench_hrtf_panners
  Instructions:          1782302026 (-8.632491%)
  L1 Accesses:           2557558270 (-12.32053%)
  L2 Accesses:             26885318 (-24.70701%)
  RAM Accesses:              175473 (+20.53124%)
  Estimated Cycles:      2698126415 (-12.97978%)


@b-ma
Copy link
Collaborator

b-ma commented Oct 18, 2023

Cool thanks, as far as I can tell looks good to me!

@orottier orottier merged commit da7727d into main Oct 18, 2023
@orottier orottier deleted the feature/hrtf-init-performance branch October 18, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants