Prevent the wpt-runner from crashing by avoiding some panics #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orottier
commented
Dec 2, 2023
src/render/quantum.rs
Outdated
| @@ -573,7 +573,8 @@ impl AudioRenderQuantum { | |||
| .zip(center.iter()) | |||
| .for_each(|(r, c)| *r += sqrt05 * c); | |||
| } | |||
|
|
|||
| _ => (), | |||
There was a problem hiding this comment.
I think I will stick to the firefox implementation for upmixing/downmixing: https://searchfox.org/mozilla-central/source/dom/media/AudioChannelFormat.h
This means, ignore any channel count > 6, but do provide all implementations of N -> M channels with N, M in [1, 6]
and resort to discrete mixing for channel counts > 6. Mixing is now panic free.
orottier
changed the title
|
Looks noce to me! The strategy for up/down mix is sensible indeed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are needed to make the wpt runner in the node bindings project work