Implements skip option or skipLaunch4j property #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garretwilson does it meet your requirements? |
Without testing it, it looks like what I need. (See the typo I found above.) |
typo? |
|
I added a comment on line 802. Did it not show up? |
Nope, you must submit your review first |
|
I found it, already fixed :) |
| * @return true to skip execution | ||
| */ | ||
| private boolean skipExecution() { | ||
| getLog().debug("skip = " + System.getProperty("skipLaunch4j")); |
There was a problem hiding this comment.
Is this a typo? Should it be "skip = " + skip?
Oh! Good to know. (I've been reviewing using other platforms for the past few years.) Well, looks like you already caught it anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can either use
<skip>true</skip>in the configuration or provide-DskipLaunch4jproperty to JVM.Closes #189