Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for unwrapped jar #55

Merged
merged 1 commit into from
May 8, 2017

Conversation

renelink
Copy link
Contributor

@renelink renelink commented May 1, 2017

The jar file must not be added to the launch4j config if dontWrapJar is
enabled. Otherwise it would result in a

net.sf.launch4j.BuilderException: Specify runtime path of the jar relative
to the executable.

The jar file must not be added to the launch4j config if dontWrapJar is
enabled. Otherwise it would result in a

net.sf.launch4j.BuilderException: Specify runtime path of the jar relative
to the executable.
@lukaszlenart
Copy link
Collaborator

LGTM 👍

@lukaszlenart lukaszlenart merged commit f776f3f into orphan-oss:master May 8, 2017
@gino0631
Copy link

gino0631 commented Jun 4, 2017

I'm afraid this is wrong.

As per documentation, it is OK to specify a jar and set dontWrapJar to true, and after upgrade to 1.7.17 I started getting:
net.sf.launch4j.BuilderException: Specify runtime path of a jar or the classpath.

@lukaszlenart
Copy link
Collaborator

hm... @gino0631 looks like you are right, I will revert to the previous behaviour.

@TheLQ
Copy link

TheLQ commented Jun 13, 2017

.17 with dontWrapJar=true doesn't seem to make a usable executable. In my case the exe is built but when ran it just exits immediately or the Java help is shown to the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants