Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

231 save observation not working #238

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

AllanEngland
Copy link
Contributor

Finish the GUI functionality to support multiple targets per observation. Should also fix any errors that were happening when adding and editing observations.

@AllanEngland AllanEngland linked an issue Aug 15, 2024 that may be closed by this pull request
@DJWalker42
Copy link
Contributor

DJWalker42 commented Aug 16, 2024

Just to point out that this is effected by the empty strings being fetched as null/undefined when the 'notes' field of a timing window is left empty. You can see this when you create a new proposal, add targets, add a technical goal, create an observation with a Timing Window but leave the notes blank, then click on the 'Edit' button for that observation. But this is a separate issue.

Obviously, this issue is relevant to master - not just this branch, so I've made a specific, separate issue, this branch should be merged.

@AllanEngland AllanEngland merged commit 52e0590 into master Aug 16, 2024
1 check passed
@AllanEngland AllanEngland deleted the 231-save-observation-not-working branch August 16, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save Observation not working
2 participants