Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct json syntax for module settings #20

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

carehart
Copy link
Contributor

Using the provided example was getting a compile error on startup of bx when using this module.

The json offered here (such as to be put in boxlang.json) is not syntactically correct, in that it uses name = val for most settings, when instead it should be "name" : val.

It looks like someone copied it from the settings code offered at the TOP of the page...but that's for use in ModuleConfig.bx, wihch is code rather than json...but they'd corrected only the "engine" setting and left the others unchanged, thus this error.

Type of change

Please delete options that are not relevant.

  • Bug Fix
  • Improvement
  • New Feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ x] This change requires a documentation update

Using the provided example was getting a compile error on startup of bx when using this module.
@carehart
Copy link
Contributor Author

As a follow-up to my first comment, I want to note as well that the code offered there in the TOP section is also no longer in sync with what comes out of the box in the ModuleConfig.bx (as found in \BoxLang\modules\bx-compat-cfml\ installed yesterday).

There are several more lines in the code that are not reflected here, but it's not as important as this json as the code seems more for documentation than actual use (whereas the boxlang.json has zero modules installed, and we DO need to rely on this page for clarification of what to put in there).

Anyway, I didn't want to presume to propose changing the "code" section at the top, as I didn't know the purpose for it being there, and whether the author may have preferred to not yet sync that with the actual code in the .bx file.

@bdw429s
Copy link
Contributor

bdw429s commented Jan 9, 2025

@lmajano Can you review this pull?

@lmajano lmajano merged commit ef2e6b0 into ortus-boxlang:development Jan 13, 2025
1 check passed
@carehart
Copy link
Contributor Author

Hi, guys. I got notified of the acceptance/merge of the PR. Thanks. But the doc page itself remains unchanged: https://www.forgebox.io/view/bx-compat-cfml

I do appreciate that it may simply take time to work it's way to the site, but I ask because I got an email reporting, "[ortus-boxlang/bx-compat-cfml] PR run failed at startup: Pull
Requests, Attempt #2 - Correct json syntax for module settings (90546bb)
". I don't find more detail in the link for the workflow that was offered with the email.

Is this perhaps some common challenge and it just may take some more time before the forgevix page reflects the change? (FWIW, I did clear cache in my browser, so that's not the issue.)

@lmajano
Copy link
Contributor

lmajano commented Jan 13, 2025 via email

@bdw429s
Copy link
Contributor

bdw429s commented Jan 13, 2025

What Luis said is half true :) Your change DID publish to ForgeBox and IS visible here
https://www.forgebox.io/view/bx-compat-cfml/version/1.17.0-snapshot
Note, ForgeBox archives the description for each version individually, so you can go back in time and see what the description was for a given package at a given version. So, the build did run and published a new 1.17.0-snapshot version which has your updated description. The reason you don't see it when you visit the page https://www.forgebox.io/view/bx-compat-cfml/ is because that page is showing the latest stable stable version of 1.16.0+22 by default! And the version 1.16.0 has the old description.
ForgeBox always defaults to the latest stable version (unless all versions are pre-releases) So, what Luis meant was when we publish a major version next, you'll see your new description on the default forgebox homepage for that package.

@carehart
Copy link
Contributor Author

carehart commented Jan 13, 2025 via email

@bdw429s
Copy link
Contributor

bdw429s commented Jan 13, 2025

And I guess it’s a bit of a bummer if the change to a description HAS to be tied to a release

That's because it makes sense in most cases :) Usually descriptions include installation directions, usage direction, and docs which are tied to the features in that specific release. Consider if we added a new feature to a snapshot release and updated the documentation in the readme to match. We wouldn't want those new docs to be "live" on the default forgebox page prior to that feature actually being released as the default stable version! That would create even more confusion. Furthermore, if you're someone using an older version of a module, you can always navigate to the description that corresponds with that version, so you can be sure you're not reading docs that don't apply to your version.

Luis could also merge your commit into the master branch as well, and re-run the stable build, or just run a local publish command. In this case, we cut new versions of these modules on a regular basis with our weekly betas, so it will just be a matter of days before another compat release is cut and the issue resolves itself.

@carehart
Copy link
Contributor Author

carehart commented Jan 14, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants