Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add scopes validator for logical evalulation #1608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add scopes validator for logical evalulation #1608

wants to merge 1 commit into from

Conversation

JarekKa
Copy link

@JarekKa JarekKa commented Dec 13, 2023 •
edited
Loading

Related Issue or Design Document

ory/oathkeeper#1129

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Corresponding changes in oathkeeper: ory/oathkeeper#1143

@JarekKa JarekKa marked this pull request as draft December 13, 2023 08:54
@JarekKa JarekKa mentioned this pull request Dec 13, 2023
Open
7 tasks
@JarekKa JarekKa marked this pull request as ready for review December 15, 2023 11:38
@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label Feb 19, 2024
@hamzabouissi
Copy link

any update on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmherrmann kmherrmann Awaiting requested review from kmherrmann

@vinckr vinckr Awaiting requested review from vinckr vinckr is a code owner

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
upstream Issue is caused by an upstream dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JarekKa @hamzabouissi @vinckr