Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly set default value for checkboxes #314

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.69%. Comparing base (071c0ff) to head (43a1be9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
- Coverage   43.73%   43.69%   -0.05%     
==========================================
  Files         135      135              
  Lines        1932     1934       +2     
  Branches      279      280       +1     
==========================================
  Hits          845      845              
- Misses       1080     1082       +2     
  Partials        7        7              
Components Coverage Δ
@ory/elements-react 38.09% <0.00%> (-0.05%) ⬇️
@ory/nextjs 65.97% <ø> (ø)

@jonas-jonas jonas-jonas merged commit 81aa35d into main Dec 17, 2024
13 of 15 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/fixCheckboxDefaultValues branch December 17, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant