Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support in README #1117

Merged
merged 3 commits into from
Jul 11, 2023
Merged

chore: support in README #1117

merged 3 commits into from
Jul 11, 2023

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Jul 6, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@vinckr vinckr requested a review from aeneasr as a code owner July 6, 2023 13:39
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1117 (3db1e07) into master (3a716f2) will not change coverage.
The diff coverage is n/a.

❗ Current head 3db1e07 differs from pull request most recent head b096771. Consider uploading reports for the commit b096771 to get more accurate results

@@           Coverage Diff           @@
##           master    #1117   +/-   ##
=======================================
  Coverage   78.17%   78.17%           
=======================================
  Files          80       80           
  Lines        3853     3853           
=======================================
  Hits         3012     3012           
  Misses        566      566           
  Partials      275      275           

kmherrmann
kmherrmann previously approved these changes Jul 6, 2023
@aeneasr aeneasr merged commit 56779c4 into master Jul 11, 2023
20 of 21 checks passed
@aeneasr aeneasr deleted the support-readme branch July 11, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants