Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to node 20 for building assets. Change to using Vite from CRA. #249

Merged
merged 79 commits into from
Aug 15, 2024
Merged

Upgrade to node 20 for building assets. Change to using Vite from CRA. #249

merged 79 commits into from
Aug 15, 2024

Conversation

tuj
Copy link
Contributor

@tuj tuj commented Jun 27, 2024 •
edited
Loading

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/1765

Description

  • Migrate from Cypress to playwright
  • Migrate from CRA (create-react-app) to Vite
  • Upgrade node from 14 -> 20
  • Changed from vite CJS to ESM.
  • Removed array spread.
  • Fixed HMR setup.
  • Upgraded @fortawesome/react-fontawesome, react-quill, react-toastify.
  • Removed unused react-dayjs.
  • Remove default props from the project.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

sinejespersen and others added 30 commits June 3, 2024 12:28
@sinejespersen
1541: remove os2display-grid-generator temp, will re-add
2dd68fa
@sinejespersen
1541: change lodash imports and dependency to avoid tree shaking
e88ec3e
@sinejespersen
1541: yarn upgrade
4770389
@sinejespersen
1541: remove unused dependencies
ae4b93c
@sinejespersen
1541: initial work on vite and upgrade node
1645604
@sinejespersen
1541: remote component now works
bd83e61
@sinejespersen
1541: readd lodash tree-shaking
aa45f50
@sinejespersen
1541: readd os2display-grid-generator
d14138b
@sinejespersen
1541: readd os2display-grid-generator
230c7fd
@sinejespersen
1541: changelog
2a150da
@sinejespersen
1541: correct tiny error, uniqwith instead of uniqWith in import
75174ce
@sinejespersen
1541: add eslint to package.json
339228e
@sinejespersen
1541: remove healthcheck
319745d
@sinejespersen
1541: reverse port 3000
4743c03
@sinejespersen
1541: move eslint to dev dependencies
120ddee
@sinejespersen
1541: update changelog to reflect new repo
145e99b
@sinejespersen
1541: remove unused path import
4c91ea8
@sinejespersen
Merge pull request #2 from aroskanalen/feature/1541-update-node-migra…
00955c1 
…te-CRA-to-vite

1541 update node migrate cra to vite
@sinejespersen
1541: initial work on vite and upgrade node
214dcb3
@sinejespersen
1541: add eslint to package.json
e21aacd
@sinejespersen
1541: initial cypress to playwright
41542d4
@sinejespersen
1541: fix baseurl
02c4810
@sinejespersen
1541: update readme with playwright
41c27a9
@sinejespersen
1541: remove cypress specific linting
5486877
@sinejespersen
1541: add yarn.lock without cypress linting
9493161
@sinejespersen
1541: change sdf to localScreenGroup
1c5c61a
@sinejespersen
1541: campaigntests
78e2596
@sinejespersen
1541: delete campaign cypress tests
b527c22
@sinejespersen
1541: delete slide cypress tests
aff20a4
@sinejespersen
1541: delete cypress login tests
3445905
tuj added 14 commits June 18, 2024 10:37
@tuj
173: Removed defaultProps
66d84c7
@tuj
173: Upgraded modules to avoid warnings
51355e2
@tuj
173: Updated changelog
b87ea3e
@tuj
173: Fixed HMR setup
31485e6
@tuj
173: Removed array spread
3e4568a
@tuj
Merge pull request #3 from aroskanalen/feature/remove-default-props
30ac9cd 
Remove default props from the project
@tuj
Merge branch 'develop' into feature/module-upgrades
ac8652c
@tuj
Merge pull request #4 from aroskanalen/feature/module-upgrades
5dbf83c 
Upgraded modules to avoid warnings
@tuj
Merge branch 'develop' into feature/hmr
7a52a3e
@tuj
Merge pull request #5 from aroskanalen/feature/hmr
a2022b2 
Fixed HMR setup
@tuj
Merge branch 'develop' into feature/remove-array-spread
06012b8
@tuj
Merge pull request #6 from aroskanalen/feature/remove-array-spread
7692533 
Removed array spread
@tuj
173: Fixed HMR setup
2d8dea6
@tuj
Merge pull request #7 from aroskanalen/feature/hmr-2
4a8b2ec 
Fixed HMR setup
@tuj tuj added the enhancement New feature or request label Jun 27, 2024
@tuj tuj requested a review from sinejespersen June 27, 2024 09:06
@tuj tuj self-assigned this Jun 27, 2024
sinejespersen
sinejespersen previously approved these changes Jun 28, 2024
View reviewed changes
@tuj tuj merged commit a38cbcb into os2display:develop Aug 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinejespersen sinejespersen sinejespersen left review comments

Assignees

@tuj tuj

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuj @sinejespersen