Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ouiaIds for import Modal and button #2192

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

jrusz
Copy link
Collaborator

@jrusz jrusz commented Jun 27, 2024

Adding some missing ouiaIds.

Copy link
Collaborator

@regexowl regexowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@regexowl regexowl enabled auto-merge (rebase) June 28, 2024 06:47
@regexowl
Copy link
Collaborator

/retest

Adding some missing ouiaIds.
@jrusz
Copy link
Collaborator Author

jrusz commented Jun 28, 2024

Stage workers seem to be sick, since it's just adding ouiaId we can merge this with failing pr_check, right?

@InsightsDroid
Copy link

❗ Outdated dependencies error

  • Installed version of @redhat-cloud-services/frontend-components-config (5.0.5) is older than required version (6.0.0)

@regexowl
Copy link
Collaborator

regexowl commented Jun 28, 2024

Stage workers seem to be sick, since it's just adding ouiaId we can merge this with failing pr_check, right?

Yup, we can for sure! Would to like to get it merged right away? I'd just need to temporarily switch off the "required" for the check which is no problem at all if it's blocking you.

Otherwise I'd let it run and merge if it fails again (one PR passed pr_check 14 minutes ago).
edit: Nevermind, let's just merge right away

@regexowl regexowl merged commit 9b82b22 into osbuild:main Jun 28, 2024
4 of 5 checks passed
@jrusz
Copy link
Collaborator Author

jrusz commented Jun 28, 2024

Stage workers seem to be sick, since it's just adding ouiaId we can merge this with failing pr_check, right?

Yup, we can for sure! Would to like to get it merged right away? I'd just need to temporarily switch off the "required" for the check which is no problem at all if it's blocking you.

Otherwise I'd let it run and merge if it fails again (one PR passed pr_check 14 minutes ago).

Thanks, I was just about to write that I can deploy in ephemeral and we can wait for the issue to get fixed, but this is better 😅

@jrusz jrusz deleted the import-ouia branch June 28, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants