-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds initial implementation for the fedramp-transform command #27
Conversation
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Initial population is control origination in the control summary table Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
trestle_fedramp/core/ssp_reader.py
Outdated
CUST_CONFIGURED = 'customer-configured' | ||
CUST_PROVIDED = 'customer-provided' | ||
INHERITED = 'inherited' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these short names be in a const file? Also are these defined by FedRAMP or us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are defined by FedRAMP here. I went back and forth over whether I should define them here or parse the xml file. I ended up defining them since the values seem to be very stable, but I can also see how that would not scale as easily as we add more FedRAMP specific values. Interested in your thoughts since fedramp
resources are already being copied over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also wanted to add that the control origination values in the xml do not cover the hybrid
or shared
values that are check boxes on the template, but the FedRAMP SSP template shows examples with multiple control origination values. So the logic on handling multiple control origination values and how they translate to hybrid
and shared
is defined here.
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@vikas-agarwal76 Putting this back into draft to address feedback I received around which check boxes are marked when properties are present (i.e. supporting multiple boxes being checked instead of a single box for each control) |
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@vikas-agarwal76 I addressed your comment about putting the short-labels in the |
Closing in favor of #39 |
Types of changes
compliance-trestle
PR)compliance-trestle
PR)Summary
Blocked by #30
Partially addresses #20
This creates the
fedramp-transform
command and the initial classes.This only populates the
control origination
values.The description, implementation status, and parameter values will be on follow-on PRs.
Key links: