Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds control implementation response population to fedramp-transforms #29

Closed
wants to merge 13 commits into from
Closed

feat: adds control implementation response population to fedramp-transforms #29

wants to merge 13 commits into from

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Feb 27, 2024 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Blocked by/Stacked with #27

Partially addresses #20

Adds processing of control description responses in the fedramp-transform command

Additional Notes

There is a commit that adds component filtering for responses, but it removed by a later commit. This requirement can be fulfilled by trestle ssp-filter so I wanted to avoid duplicating that logic here.

Key links:

@jpower432
chore: adds FedRAMP SSP Appendix A template to resources
17adc20 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
feat: adds fedramp-transform command
6d7033d 
Initial population is control origination in the
control summary table

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
test: adds unit test for transform command and related classes
e3704f4 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
fix: handles control with no labels
0e0670b 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: moves FEDRAMP constant from class data to const.py
2477f79 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
feat: adds support for multiple checked boxes
7227207 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
feat: updates FedRAMPSSPReader to collect control responses
2f2fd73 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
feat: adds FedRampDocx and ControlImplementation description classes
5c93eb0 
FedRampDocx is a single class to handle as template population and
ControlImplementationDescriptions handle control responses for
each control and parts

BREAKING CHANGE: Adds a breaking API to ControlSummaries class

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: updates class organization and add check for invalid control o…
afc9313 
…rigination

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
feat: adds filtering for responses by component
825e700 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
test: moves check functions to test_utils and adds test in transform_…
9c30499 
…test.py

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: removes include_components and tests
dbe66f5 
Trestle already have filtering capabilites for components. This plugin
should not duplicate that logic.

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: updates docx response format in the cell
26d4166 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 mentioned this pull request Mar 7, 2024
Closed
9 tasks
@jpower432 jpower432 mentioned this pull request Apr 15, 2024
Closed
7 tasks
@jpower432 jpower432 added this to the 0.4.0 milestone Apr 26, 2024
@jpower432
Copy link
Member Author

Closing in favor of #39

@jpower432 jpower432 closed this Jul 29, 2024
@jpower432 jpower432 mentioned this pull request Jul 29, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jpower432