Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump trestle version to major version 3 #44

Merged
merged 3 commits into from
Jul 19, 2024
Merged

chore(deps): bump trestle version to major version 3 #44

merged 3 commits into from
Jul 19, 2024

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Jul 15, 2024 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

The following change updates the plugin to use the latest major version of compliance-trestle. It includes:

  • Dropping support for 3.8. Adding support for 3.10 and 3.11 to match trestle
  • Replacing the use of pkg_resources, deprecated in 3.11

Closes #42

Key links:

@jpower432
chore(deps): updates trestle to new major version
3ee2401 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore(deps): drops python 3.8 support, adds 3.10 and 3.11
3bbc6c2 
Aligns supported python versions with compliance-trestle

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: replaces pkg_resources with importlib.resources
4e484d6 
pkg_resources is deprecated in Python 3.11

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
gvauter
gvauter approved these changes Jul 15, 2024
View reviewed changes
Copy link

@gvauter gvauter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vikas-agarwal76
vikas-agarwal76 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit b16607d into develop Jul 19, 2024
9 checks passed
jpower432 added a commit to jpower432/compliance-trestle-fedramp that referenced this pull request Jul 22, 2024
@jpower432
chore(deps): bump trestle version to major version 3 (oscal-compass#44)
3148ec0 
* chore(deps): updates trestle to new major version

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>

* chore(deps): drops python 3.8 support, adds 3.10 and 3.11

Aligns supported python versions with compliance-trestle

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>

* chore: replaces pkg_resources with importlib.resources

pkg_resources is deprecated in Python 3.11

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>

---------

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikas-agarwal76 vikas-agarwal76 vikas-agarwal76 approved these changes

@gvauter gvauter gvauter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests are failing on python 3.8 on the macos runner
3 participants
@jpower432 @gvauter @vikas-agarwal76