Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates build command to install deps into container #55

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Sep 9, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Closes #54

Installed dependencies during the build command with semantic release

Tested and verified the fix with GitHub actions on my fork:
here
here
here

Key links:

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
Copy link
Member Author

@vikas-agarwal76 @butler54 Added a solution here that deviates from how the workflow is done in trestle. Not sure what configuration differences there are between this project and trestle, but I also could not find the step in the logs for the most recent trestle release for comparison.

Copy link
Collaborator

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit 868716f into develop Sep 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The deploy job failing during semantic release step
2 participants