Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document Julia.GAP.Obj(x,true), add tests #925

Merged

Conversation

ThomasBreuer
Copy link
Member

This is the promised follow-up of #910.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #925 (8e68d03) into master (47e264d) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
+ Coverage   75.53%   75.58%   +0.04%     
==========================================
  Files          51       51              
  Lines        4165     4165              
==========================================
+ Hits         3146     3148       +2     
+ Misses       1019     1017       -2     
Files Changed Coverage Δ
pkg/JuliaInterface/gap/convert.gd 100.00% <ø> (ø)
src/types.jl 80.00% <ø> (ø)

... and 1 file with indirect coverage changes

@ThomasBreuer
Copy link
Member Author

The test OscarCI / matching: [Oscar#master] - ubuntu-latest, julia ~1.6.0-0 (pull_request) fails:

du Val Tester: Error During Test at /home/runner/work/GAP.jl/GAP.jl/oscar-dev/Oscar/test/AlgebraicGeometry/Schemes/duValSing.jl:12
  Test threw exception
  Expression: is_du_val_singularity(X, J3) == false
  Ideal does not describe a single K-point

This is almost the same error as in the failures of oscar-system/Oscar.jl/pull/2410 and oscar-system/Oscar.jl/pull/2528.

@fingolfin
Copy link
Member

This is oscar-system/Oscar.jl#2531 -- it is a bug in Singular that needs to be fixed there, which should be in the works

@ThomasBreuer
Copy link
Member Author

Thanks @fingolfin. Then I regard this pull request as ready for review.
(Is it a reasonable idea to document Julia.GAP.Obj in the JuliaInterface manual as if it were a GAP function?)

@fingolfin
Copy link
Member

(Is it a reasonable idea to document Julia.GAP.Obj in the JuliaInterface manual as if it were a GAP function?)

IMO it is1

@fingolfin fingolfin merged commit 5f85453 into oscar-system:master Jul 26, 2023
13 of 14 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_JuliaInterface_GAP.Obj branch July 26, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants