discard imprimitive vectors

oscar-system · Sep 26, 2024 · 20eff62 · 20eff62
1 parent bf290b9
commit 20eff62
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/NumberTheory/vinberg.jl b/src/NumberTheory/vinberg.jl
@@ -289,10 +289,10 @@ function vinberg_algorithm(Q::ZZMatrix, upper_bound; v0=ZZ[0;]::ZZMatrix, root_l
     @vprintln :Vinberg 1 "computing roots of squared length v^2=$(k) and v.v0 = $(n)"
     possible_Vec = short_vectors_affine(Q, v0, QQ(n), k)
     for v in possible_Vec
-      if v in roots
-        continue
+      if !isone(reduce(gcd, v))
+        # v must be primitive.
+        continue 
       end
-      v = _rescale_primitive(v)
       mul!(Qv, Q, transpose(v))
       #Qv = Q*transpose(v)
       if !(divisibilities isa Nothing)