Skip to content

Commit

Permalink
Suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
joschmitt committed Apr 10, 2024
1 parent 808ab14 commit 253c5e4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ function Base.setindex!(C::WeakComposition, x::IntegerUnion, i::IntegerUnion)
end

function Base.copy(C::WeakComposition)
return weak_composition(copy(data(C)))
return weak_composition(copy(data(C)), check = false)
end

################################################################################
Expand Down
4 changes: 2 additions & 2 deletions src/aliases.jl
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ function n_rays end
function n_vertices end

function number_of_partitions end
function number_of_weak_compositions end
function number_of_patches end
function number_of_weak_compositions end

# these are kept for compatibility with Graphs.jl / GraphsBase.jl
@alias ne n_edges
Expand All @@ -59,8 +59,8 @@ function number_of_patches end
@alias number_of_vertices n_vertices

@alias n_partitions number_of_partitions
@alias n_weak_compositions number_of_weak_compositions
@alias n_patches number_of_patches
@alias n_weak_compositions number_of_weak_compositions

# aliases for consistency with oscar style
@alias n_columns ncols
Expand Down

0 comments on commit 253c5e4

Please sign in to comment.