Apply suggestions from code review

Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
oscar-system · Oct 31, 2024 · 4ef8766 · 4ef8766
1 parent 4968376
commit 4ef8766
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/docs/oscar_references.bib b/docs/oscar_references.bib
@@ -1646,7 +1646,7 @@ @InProceedings{Kal02
   shortseries   = {Adv. Stud. Pure Math.},
   shortpublisher= {Math. Soc. Japan},
   location      = {Tokyo},
-  dor           = {10.2969/aspm/03310121}
+  doi           = {10.2969/aspm/03310121}
 }
 
 @Article{Kem02,

diff --git a/src/Combinatorics/Graphs/functions.jl b/src/Combinatorics/Graphs/functions.jl
@@ -1172,9 +1172,7 @@ end
 function graph_from_edges(::Type{T},
                           edges::Vector{Edge},
                           n_vertices::Int=-1) where {T <: Union{Directed, Undirected}}
-  isempty(edges) && return Graph{T}(n_vertices)
-
-  n_needed = maximum(reduce(append!,[[src(e),dst(e)] for e in edges];))
+  n_needed = maximum(reduce(append!,[[src(e),dst(e)] for e in edges];); init=0)
   @req (n_vertices >= n_needed || n_vertices < 0)  "n_vertices must be at least the maximum vertex in the edges"
 
   g = Graph{T}(max(n_needed, n_vertices))